Add collectives-westend and glutton-westend runtimes#2024
Merged
Conversation
bkontur
reviewed
Nov 14, 2023
cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Nov 14, 2023
bkontur
reviewed
Nov 14, 2023
cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
bkontur
reviewed
Nov 14, 2023
cumulus/parachains/runtimes/collectives/collectives-westend/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
bkontur
approved these changes
Nov 14, 2023
Contributor
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
looks good, just left a few nits
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
liamaharon
reviewed
Nov 15, 2023
Contributor
liamaharon
left a comment
liamaharon
left a comment
There was a problem hiding this comment.
Appreciate if you could add migration CI for collectives westend to .gitlab/pipeline/check.yml in this PR, see #2336 for reference.
Should be something like:
# Check runtime migrations for Parity managed collectives chains
check-runtime-migration-collectives-westend:
stage: check
extends:
- .docker-env
- .test-pr-refs
- .check-runtime-migration
variables:
NETWORK: "collectives-westend"
PACKAGE: "collectives-westend-runtime"
WASM: "collectives_westend_runtime.compact.compressed.wasm"
URI: "wss://westend-collectives-rpc.polkadot.io:443"
|
The CI pipeline was cancelled due to failure one of the required jobs. |
ordian
added a commit
that referenced
this pull request
Nov 22, 2023
* tsv-disabling: (46 commits) frame-system: Add `last_runtime_upgrade_spec_version` (#2351) [testnet] Remove Wococo stuff from BridgeHubRococo/AssetHubRococo (#2300) xcm: SovereignPaidRemoteExporter: remove unused RefundSurplus instruction (#2312) Add `collectives-westend` and `glutton-westend` runtimes (#2024) Identity Deposits Relay to Parachain Migration (#1814) [CI] Prepare CI for Merge Queues (#2308) Unify `ChainSync` actions under one enum (follow-up) (#2317) pallet-xcm: use XcmTeleportFilter for teleported fees in reserve transfers (#2322) Contracts expose pallet-xcm (#1248) add NodeFeatures field to HostConfiguration and runtime API (#2177) statement-distribution: support inactive local validator in grid (#1571) change prepare worker to use fork instead of threads (#1685) chainHead/tests: Fix clippy (#2325) Contracts: Bump contracts rococo (#2286) Add simple collator election mechanism (#1340) chainHead: Remove `chainHead_genesis` method (#2296) chainHead: Support multiple hashes for `chainHead_unpin` method (#2295) Add environment to claim workflow (#2318) PVF: fix detection of unshare-and-change-root security capability (#2304) xcm-emulator: add Rococo<>Westend bridge and add tests for assets transfers over the bridge (#2251) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add collectives and glutton parachain westend runtimes to prepare for #1737.
The removal of system parachain native runtimes #1737 is blocked until chainspecs and runtime APIs can be dealt with cleanly (merge of #1256 and follow up PRs).
In the meantime, these additions are ready to be merged to
master, so I have separated them out into this PR.Also marked
bridge-hub-westendas unimplemented in line with this issue.TODO
command-botbenchmarkscommand-bot-scriptsbenchmarks