Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
the
R0-no-crate-publish-required
Contributor
|
I think it makes sense to run it in one job with zepter as you suggested. I'd put the script into the |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Member
Author
Okay thanks! I will do it as another MR when the stuff in the other MR is sorted out. |
ordian
approved these changes
Oct 16, 2023
bkchr
approved these changes
Oct 16, 2023
tdimitrov
pushed a commit
that referenced
this pull request
Oct 23, 2023
Changes: - Add missing crate to the workspace - Remove versions from local dependency links Maybe it is finally worth it to add this scrip to the CI to find these things earlier: [check-deps.py](https://github.com/ggwpez/substrate-scripts/blob/master/import-runtime-repos/check-deps.py). @paritytech/ci what would be the best location for that check? It takes only a second to run, so maybe we can squeeze it into one of the existing checks? Otherwise creating a new GH workflow feels a bit wasteful... maybe i can group it with #1831 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Changes: - Add missing crate to the workspace - Remove versions from local dependency links Maybe it is finally worth it to add this scrip to the CI to find these things earlier: [check-deps.py](https://github.com/ggwpez/substrate-scripts/blob/master/import-runtime-repos/check-deps.py). @paritytech/ci what would be the best location for that check? It takes only a second to run, so maybe we can squeeze it into one of the existing checks? Otherwise creating a new GH workflow feels a bit wasteful... maybe i can group it with paritytech#1831 --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* fix clippy issues * fix? * fix? * forget about extra_unused_type_parameters lint for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Maybe it is finally worth it to add this scrip to the CI to find these things earlier: check-deps.py.
@paritytech/ci what would be the best location for that check?
It takes only a second to run, so maybe we can squeeze it into one of the existing checks?
Otherwise creating a new GH workflow feels a bit wasteful... maybe i can group it with #1831