Skip to content

extract amount method for fungible/s Imbalance#1847

Merged
muharem merged 1 commit intomasterfrom
muharem-extract-imbalance
Oct 16, 2023
Merged

extract amount method for fungible/s Imbalance#1847
muharem merged 1 commit intomasterfrom
muharem-extract-imbalance

Conversation

@muharem
Copy link
Copy Markdown
Contributor

@muharem muharem commented Oct 11, 2023

Introduces an extract amount method for fungible/s Imbalance.

@muharem muharem added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 11, 2023
@muharem muharem requested review from a team October 11, 2023 10:57
@muharem muharem changed the title Extract amount method for fungible/s Imbalance extract amount method for fungible/s Imbalance Oct 11, 2023
@muharem muharem merged commit c422e3f into master Oct 16, 2023
@muharem muharem deleted the muharem-extract-imbalance branch October 16, 2023 15:17
tdimitrov pushed a commit that referenced this pull request Oct 23, 2023
Introduces an `extract` amount method for `fungible/s` `Imbalance`.
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2024
Implements an XCM executor `WeightTrader`, facilitating fee payments in
any asset that can be exchanged for a native asset.

A few constraints need to be observed:
- `buy_weight` and `refund` operations must be atomic, as another weight
trader implementation might be attempted in case of failure.
- swap credit must be utilized since there isn’t an account to which an
asset of some class can be deposited with a guarantee to meet the
existential deposit requirement. Also, operating with credits enhances
the efficiency of the weight trader -
#1677

related PRs:
- (depends) #2031
- (depends) #1677
- (caused) #1847
- (caused) #1876

// DONE: impl `OnUnbalanced` for a `fungible/s` credit
// DONE: make the trader free from a concept of a native currency and
drop few fallible conversions. related issue -
#1842
// DONE: tests

---------

Co-authored-by: joe petrowski <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
Introduces an `extract` amount method for `fungible/s` `Imbalance`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants