statement-distribution: validator disabling#1841
Merged
Conversation
ordian
added
T0-node
ordian
changed the title
ordian
force-pushed
the
ao-disabling-statement-distribution
branch
from
e333fa8 to
9f6736d
Compare
tdimitrov
reviewed
Nov 3, 2023
tdimitrov
reviewed
Nov 3, 2023
tdimitrov
reviewed
Nov 3, 2023
Contributor
|
I'm not familiar with statement-distribution and I can't provide any sensible feedback, but changes look sane to me. |
18 tasks
Member
|
Fixes #1591 |
eskimor
reviewed
Nov 8, 2023
Member
eskimor
left a comment
eskimor
left a comment
There was a problem hiding this comment.
Are we properly disabling both in grid and in cluster distribution?
ordian
force-pushed
the
ao-disabling-statement-distribution
branch
from
c3bb3f4 to
551219b
Compare
ordian
changed the base branch from
tsv-disabling
to
ao-backport-backing-disabling
tdimitrov
approved these changes
Dec 21, 2023
Contributor
tdimitrov
left a comment
tdimitrov
left a comment
There was a problem hiding this comment.
Approving with a disclaimer: this is my first encounter with statement-distribution 😕
mrcnski
approved these changes
Dec 21, 2023
polkadot/node/network/statement-distribution/src/v2/requests.rs
Outdated
Show resolved
Hide resolved
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1591.
The purpose of this PR is filter out backing statements from the network signed by disabled validators. This is just an optimization, since we will do filtering in the runtime in #1863 to avoid nodes to filter garbage out at block production time.