Skip to content

[DNM] test#1743

Closed
altaua wants to merge 1 commit intomasterfrom
mira/test
Closed

[DNM] test#1743
altaua wants to merge 1 commit intomasterfrom
mira/test

Conversation

@altaua
Copy link
Copy Markdown

@altaua altaua commented Sep 28, 2023

No description provided.

@altaua altaua self-assigned this Sep 28, 2023
jobs:
review-approvals:
runs-on: ubuntu-latest
environment: master
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In afraid this won’t work until we merge to master, as the event triggering this is pull_request_target and that uses the workflow file available in the master branch.

Copy link
Copy Markdown
Author

@altaua altaua Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, indeed! That's why I waited with pr'ing this until I had a screenshot of the config, I don't like blindly merging untested changes.

@altaua altaua closed this Sep 29, 2023
@altaua altaua deleted the mira/test branch September 29, 2023 12:03
bkchr pushed a commit that referenced this pull request Apr 10, 2024
Wait until the initialization transaction is finalized/lost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants