Skip to content

PVF worker: Maintain lists of used syscalls #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrcnski merged 12 commits into from
Oct 17, 2023
Merged

PVF worker: Maintain lists of used syscalls #1663

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f635302
Add tools for building with musl; list-syscalls.rb
mrcnski Sep 21, 2023
9d6d172
Get the syscall lists for workers
mrcnski Sep 21, 2023
9d822ab
Add note and example
mrcnski Sep 21, 2023
f1e9d15
Add tools for building with musl; list-syscalls.rb
mrcnski Sep 21, 2023
6994f5d
Get the syscall lists for workers
mrcnski Sep 21, 2023
1edf424
Add note and example
mrcnski Sep 21, 2023
9c1aeae
ci: new ci job to check syscalls used by polkadot workers
Sep 21, 2023
4bd6362
fix(list-syscalls): add missing read syscall to prepare-worker whitelist
Oct 11, 2023
7f3e387
Merge remote-tracking branch 'origin/mrcnski/ci-list-syscalls' into m…
mrcnski Oct 12, 2023
355ab24
Update syscall lists
mrcnski Oct 12, 2023
5882013
feat(list-syscalls): add explanatory error message
Oct 16, 2023
96a1500
chore(list-syscalls): enable `allow_failure` for now
Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitlab/pipeline/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,3 +523,4 @@ test-syscalls:
- if [[ "$CI_JOB_STATUS" == "failed" ]]; then
printf "The x86_64 syscalls used by the worker binaries have changed. Please review if this is expected and update polkadot/scripts/list-syscalls/*-worker-syscalls as needed.\n";
fi
allow_failure: true # TODO: remove this once we have an idea how often the syscall lists will change

@mrcnski mrcnski Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was probably added to not confuse devs who would be blocked and not know what to do.
But the syscalls should change rarely and mostly only when updating the worker code.

It can stay not required for now until we have the syscall blocking in place.