Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
gupnik
reviewed
Sep 18, 2023
| type BlockWeights = (); | ||
| type BlockLength = (); | ||
| type DbWeight = (); | ||
| type RuntimeOrigin = RuntimeOrigin; |
Contributor
There was a problem hiding this comment.
RuntimeOrigin, RuntimeCall and RuntimeEvent can also be removed now.
| #[pallet::config(with_default)] | ||
| pub trait Config: frame_system::Config { | ||
| /// The staking balance. | ||
| #[pallet::no_default] |
Contributor
There was a problem hiding this comment.
We can try using no_default_bounds for a number of them.
kianenigma
reviewed
Sep 19, 2023
| } | ||
|
|
||
| #[pallet::config] | ||
| /// Some default provided implementations of [`DefaultConfig`], which can be used to implement |
Contributor
There was a problem hiding this comment.
This can be then applies in a couple of pallets, like grandpa etc?
kianenigma
reviewed
Sep 19, 2023
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Thanks!
Please update #171 once done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.