Conversation
Not part of the core protocol. Will be added later.
nazar-pc
reviewed
Sep 14, 2023
bkchr
approved these changes
Nov 28, 2023
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Not a full expert. However, left some review as requested :P
Please revert the changes to the node template. There is really no need to add the Sassafras stuff there. Otherwise left some comments in the pallet. I think the most problematic point being the validate_unsigned that prevents nodes from outside the current active set, but part of the next active set to send their tickets.
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v1-5-0/5358/1 |
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
This PR introduces the pallet for Sassafras consensus. ## Non Goals The pallet delivers only the bare-bones and doesn't deliver support for auxiliary functionalities such as equivocation report and support for epoch change via session pallet. These functionalities were drafted in the [main PR](paritytech#1336), but IMO is better to introduce this auxiliary stuff in a follow up PR and after client code. ## Potential follow ups paritytech#2364 --------- Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: Koute <koute@users.noreply.github.com> Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
This will make more sense after paritytech#2524 since the schnorrkel type for VRF outputs is also renamed in the latest version. Can be reviewed independently though. Can be merged after paritytech#1577 so that there is less pain for @davxy. --------- Co-authored-by: Bastian Köcher <git@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the pallet for Sassafras consensus.
Note for reviewers
ignore the modifications to
substrate/bin/node-templatefolder (see before merge actions)Before merge actions:
Cargo.tomlsubstrate/bin/node-template(used only to run benches)benchmark.sh)Non Goals
The pallet delivers only the bare-bones and doesn't deliver support for auxiliary functionalities such as equivocation report and support for epoch change via session pallet.
These functionalities were drafted in the main PR, but IMO is better to introduce this auxiliary stuff in a follow up PR and after client code.
About SRS initialization
SRS material in thehttps://github.com//issues/41 context of the pallet is maintained by the
RingContextstruct.Proper construction of SRS is out of the scope of this PR and will follow an RFC dedicated to the topic to discuss the trusted setup machinery (aka ceremony).
However, regardless of the origin of the SRS, we need a way to write the constructed data into the pallet's storage.
This will be addressed in a dedicated, follow-up, PR. Currently the pallet tests are using a test string.