Merged
Conversation
s0me0ne-unkn0wn
commented
Sep 7, 2023
mrcnski
suggested changes
Sep 8, 2023
Contributor
mrcnski
left a comment
mrcnski
left a comment
There was a problem hiding this comment.
Really happy to see this!
This requires the workers to be built before running tests, right? Instructions should be added to the relevant READMEs, like we do for polkadot-test-service.
Contributor
Author
|
@mrcnski I've added a README to the PVF host integration tests directory. Not sure if it has to be added somewhere else, all the other tests seem good to go, but I may be missing something. |
mrcnski
approved these changes
Sep 10, 2023
1 task
alindima
approved these changes
Sep 11, 2023
Comment on lines
+42
to
+44
| let mut workers_path = std::env::current_exe().unwrap(); | ||
| workers_path.pop(); | ||
| workers_path.pop(); |
Contributor
There was a problem hiding this comment.
can we add this bit of logic to a helper function? it's being used from multiple places
bkchr
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #583
After the separation of PVF worker binaries, dedicated puppet workers are not needed for tests anymore. The production workers can be used instead, avoiding some code duplication and decreasing complexity.
The changes also make it possible to further refactor the code to isolate workers completely.