Skip to content

add nft apis to kusama + polkadot asset hub runtimes#1448

Closed
gilescope wants to merge 10 commits intomasterfrom
giles-add-runtime-apis
Closed

add nft apis to kusama + polkadot asset hub runtimes#1448
gilescope wants to merge 10 commits intomasterfrom
giles-add-runtime-apis

Conversation

@gilescope
Copy link
Copy Markdown
Contributor

@gilescope gilescope commented Sep 7, 2023

Now that the NFT pallet is released we should also release the NFT runtime APIs.
Tasks:

  • use associated types rather than concrete types where possible.

@gilescope gilescope added the T4-runtime_API This PR/Issue is related to runtime APIs. label Sep 7, 2023
@paritytech-ci paritytech-ci requested review from a team September 7, 2023 14:07
@gilescope gilescope marked this pull request as draft September 7, 2023 14:57
@gilescope gilescope marked this pull request as ready for review September 8, 2023 13:11
@gilescope gilescope requested a review from jsidorenko September 8, 2023 13:12
@gilescope gilescope enabled auto-merge (squash) September 9, 2023 11:27
@gilescope
Copy link
Copy Markdown
Contributor Author

(This needs to land so that the constants are exposed before the corollary can be landed in the runtime repo.)

@jsidorenko
Copy link
Copy Markdown
Contributor

It would be ideal to wait for this PR to get merged first: #1914
In that case, we won't break the public API

@gilescope
Copy link
Copy Markdown
Contributor Author

Happy to put a note on the runtime PR that we should not merge it till the PR you mentioned has landed. Agreed we want to minimise breaking changes.

@jsidorenko
Copy link
Copy Markdown
Contributor

sounds good!

@gilescope
Copy link
Copy Markdown
Contributor Author

Ok those changes are all incorporated now.

Copy link
Copy Markdown
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a Fellowship PR for Polkadot and Kusama.

auto-merge was automatically disabled November 15, 2023 13:29

Merge queue setting changed

bkchr pushed a commit that referenced this pull request Apr 10, 2024
@bkchr bkchr closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T4-runtime_API This PR/Issue is related to runtime APIs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants