Skip to content

wasm-substitutes: Use unique hash per substitute to fix caching issues #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 1 commit into from
Sep 6, 2023
+1 −1
Merged

wasm-substitutes: Use unique hash per substitute to fix caching issues #1416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion substrate/client/service/src/client/wasm_substitutes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ where
let runtime_code = RuntimeCode {
code_fetcher: &WrappedRuntimeCode((&code).into()),
heap_pages: None,
hash: Vec::new(),
hash: make_hash(&code),
Copy link
Copy Markdown
Contributor

@michalkucharczyk michalkucharczyk Sep 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this doc is outdated (guess that scale-encoding is not really needed)?

};
let version = Self::runtime_version(&executor, &runtime_code)?;
let spec_version = version.spec_version;
Expand Down