Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
the
R0-no-crate-publish-required
franciscoaguirre
approved these changes
Aug 30, 2023
rcny
approved these changes
Aug 30, 2023
Will be removed in #1304 anyway. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
gilescope
approved these changes
Aug 30, 2023
Contributor
gilescope
left a comment
gilescope
left a comment
There was a problem hiding this comment.
CI definitely bust without it.
sergejparity
approved these changes
Aug 30, 2023
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Fix deterministic WASM check Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix build-staking-miner Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Remove Kusama and Polkadot runtime-migration checks Will be removed in #1304 anyway. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
…ration (#1316) * add some tests to check integrity of chain constants + bridge configuration * try to use named parameters where possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
@alvicsam then please make these two jobs also required.