Merged
Conversation
davxy
requested review from
a team,
altonen,
andresilva,
bkchr,
dmitry-markin,
koute,
michalkucharczyk,
skunert and
the-right-joyce
skunert
approved these changes
Aug 29, 2023
Contributor
skunert
left a comment
skunert
left a comment
There was a problem hiding this comment.
Based on your previous explanations about the flow, this looks good to me!
bkchr
approved these changes
Aug 30, 2023
koute
approved these changes
Aug 30, 2023
|
|
||
| /// Configuration data that can be modified on epoch change. | ||
| #[derive( | ||
| Copy, Clone, PartialEq, Eq, Encode, Decode, RuntimeDebug, MaxEncodedLen, TypeInfo, Default, |
Contributor
There was a problem hiding this comment.
Creating this struct with Default will initialize everything to zero, including the attempts_number. Shouldn't that be at least 1 by default?
michalkucharczyk
approved these changes
Aug 31, 2023
ordian
added a commit
that referenced
this pull request
Sep 1, 2023
* master: (25 commits) fix typos (#1339) Use bandersnatch-vrfs with locked dependencies ref (#1342) Bump bs58 from 0.4.0 to 0.5.0 (#1293) Contracts: `seal0::balance` should return the free balance (#1254) Logs: add extra debug log for negative rep changes (#1205) Added short-benchmarks for cumulus (#1183) [xcm-emulator] Improve hygiene and clean up (#1301) Bump the known_good_semver group with 1 update (#1347) Renames API (#1186) Rename `polkadot-parachain` to `polkadot-parachain-primitives` (#1334) Add README to project root (#1253) Add environmental variable to track decoded instructions (#1320) Fix polkadot-node-core-pvf-prepare-worker build with jemalloc (#1315) Sassafras primitives (#1249) Restructure `dispatch` macro related exports (#1162) backing: move the min votes threshold to the runtime (#1200) Bump zstd from 0.11.2+zstd.1.5.2 to 0.12.4 (#1326) Remove `substrate_test_utils::test` (#1321) remove disable-runtime-api (#1328) [ci] add more jobs for pipeline cancel, cleanup (#1314) ...
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Introduce Sassafras primitives * Keystore workaround * Fix doc * Use in keystore * Improve bandersnatch vrf docs * Apply review suggestions * Update README * Docs improvement * Docs fix
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
* Introduce Sassafras primitives * Keystore workaround * Fix doc * Use in keystore * Improve bandersnatch vrf docs * Apply review suggestions * Update README * Docs improvement * Docs fix
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new crate with the primitives required by #41.
Quoting the crate README:
Nevertheless, the strategy here is to incrementally drain the main Sassafras PR by upstreaming smaller components in order to make the overall protocol inclusion and analysis more manageable.
The structures and functions were found to satisfy the requirements of the protocol.
A more in depth analysis of the structures obviously requires to dig into the client and frame pallets in the main PR.
This crate requires to enable bandersnatch-experimental feature in some of its dependencies.
This feature ends up being transitively enabled in:
sp-consensus-sassafras → sp-application-crypto → sp-io → sp-keystore
Follows that Bandersnatch API ends up being exposed by the
Keystoretrait and thus we require to expose these functions implementations in the client keystore (sc-keystore) as well.The (temporary)
workaround is to includesolution is to conditionally compilesc-keystoreas an optional dependency insp-consensus-sassafrasand enable it withbandersnatch-experimentalfeature on std buildssc-keystoreexperimental code using the result ofgenerate_feature_enabled_macro(see 3a1eeda)Step towards: #41
Extracted from: paritytech/substrate#11879
Superseeds: paritytech/substrate#14768