Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
@franciscoaguirre @Szegoo do we still need this |
Think this PR can be closed. I initially introduced it to work with the Uniques pallet. But I see that there is already some other implementation merged. |
|
This was closed, but we still don't have an adapter for the nonfungible v2 traits. The merged PRs were for nonfungible v1 traits. Without this, pallet-nfts can't be used with XCM. What do you think about nonfungible v1 and v2 @mrshiposha ? Is it worth it to revive this, or should we create a better set of traits for NFTs? |
|
I believe we need a better set of traits that will be more general and granular than the existing ones. Also, I think we need more granular NFT adapters. There could also be different approaches to NFT derivatives (if we consider the reserve-based model). I want to draft a PR about this (the same PR I proposed in the comment here). You'll see the concrete code there, and I will provide reasons for it in the PR description. |
This pr introduces the NonFungiblesV2Adapter as a new type for the XCM executor's AssetTransactor type, designed to work with the NFTs pallet.
Introduces:
NonFungiblesV2Adapter
MultiLocationCollectionId: Wrapper for MultiLocation that implements the Incrementable trait. The trait implementation allow the NFT's pallet CollectionId type to be a wrapped MultiLocation.
Replaces the uniques pallet with the NFTs pallet in the xcm-simulator parachain runtime.