Skip to content

Logs: add extra debug log for negative rep changes #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandreim merged 9 commits into from
Sep 1, 2023
Merged

Logs: add extra debug log for negative rep changes #1205

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
69ab461
refactor and more debug
sandreim Aug 28, 2023
0ffbd54
review
sandreim Aug 28, 2023
da77306
fix
sandreim Aug 28, 2023
19583fe
🤦
sandreim Aug 28, 2023
24acb9f
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
sandreim Aug 28, 2023
a4417d8
Merge remote-tracking branch 'origin' into sandreim/extra_rep_change_…
sandreim Aug 30, 2023
8e24389
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
sandreim Aug 30, 2023
845b3af
Merge branch 'master' into sandreim/extra_rep_change_logging
sandreim Aug 31, 2023
557ae98
Merge branch 'master' into sandreim/extra_rep_change_logging
sandreim Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions polkadot/node/subsystem-util/src/reputation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ use std::{collections::HashMap, time::Duration};

/// Default delay for sending reputation changes
pub const REPUTATION_CHANGE_INTERVAL: Duration = Duration::from_secs(30);
const LOG_TARGET: &'static str = "parachain::reputation-aggregator";

type BatchReputationChange = HashMap<PeerId, i32>;

Expand Down Expand Up @@ -75,6 +76,10 @@ impl ReputationAggregator {
peer_id: PeerId,
rep: UnifiedReputationChange,
) {
if rep.cost_or_benefit() < 0 {
gum::debug!(target: LOG_TARGET, peer = ?peer_id, ?rep, "Reduce reputation");
}

if (self.send_immediately_if)(rep) {
self.single_send(sender, peer_id, rep).await;
} else {
Expand All @@ -97,12 +102,8 @@ impl ReputationAggregator {
}

fn add(&mut self, peer_id: PeerId, rep: UnifiedReputationChange) {
if self.by_peer.is_none() {
self.by_peer = Some(HashMap::new());
}
if let Some(ref mut by_peer) = self.by_peer {
add_reputation(by_peer, peer_id, rep)
}
let by_peer = self.by_peer.get_or_insert(HashMap::new());
add_reputation(by_peer, peer_id, rep)
}
}

Expand Down