ci: fix worker binaries could not be found#1198
Merged
Conversation
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
alvicsam
approved these changes
Aug 28, 2023
Signed-off-by: Alexandru Gheorghe <[email protected]>
Contributor
Author
|
Tested in |
mrcnski
reviewed
Aug 28, 2023
Contributor
mrcnski
left a comment
mrcnski
left a comment
There was a problem hiding this comment.
Looks like all the build stuff is duplicated in the polkadot/ directory, e.g. .gitlab/pipeline/build.yml and polkadot/.gitlab/pipeline/build.yml. The more up-to-date ones seem to be in the polkadot directory. Is it supposed to be like this? 🤔
Contributor
No, we just haven't cleaned it up yet. |
Contributor
Author
@alvicsam How would you prefer to handle this, should I close this PR and you handle it on cleanup ? Ideally, we wouldn't want to keep this functionality broken for too long, but I also I'm not 100% sure if there are other things that weren't ported yet. |
Contributor
|
You've already finished it so I'd prefer to merge this one since it's urgent |
sergejparity
approved these changes
Aug 28, 2023
mateo-moon
approved these changes
Aug 28, 2023
mrcnski
approved these changes
Aug 28, 2023
sandreim
approved these changes
Aug 28, 2023
acatangiu
approved these changes
Aug 28, 2023
EgorPopelyaev
approved these changes
Aug 28, 2023
lexnv
approved these changes
Aug 28, 2023
alexggh
added
the
R0-no-crate-publish-required
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
* ci: fix worker binaries could not be found Signed-off-by: Alexandru Gheorghe <[email protected]> * Add missing bits Signed-off-by: Alexandru Gheorghe <[email protected]> * Fix malus build Signed-off-by: Alexandru Gheorghe <[email protected]> --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: Alexander Samusev <[email protected]>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Add relayer strategy * Add default relayer strategy * default relayer strategy * expose relayer strategy * fix compile * fix compile * docs * Rename Relayer to Relay, keep RelayerDecide * split `DefaultRelayerStrategy` into `AltruisticRelayerStrategy` and `RationalRelayerStrategy` * Remove relayer mode * Remove unused import * Rename `RelayerStrategy` to `RelayStrategy` * Add missing docs * clippy * clippy * clippy * clippy * Revert `relayer_mode` and add `MixStrategy` * Add `EnforcementStrategy` * fix bug and simplify relay strategy * Update message_lane_loop.rs * Update messages_target.rs * clippy * clippy * clippy * clippy * clippy * clippy * clippy * fix test * fix test * test test test fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that some of the changes in polkadot have not been migrated to polkadot-sdk, so the generated docker images fail to start, fix this by porting the changes in
scriptsdirectory that were present in: paritytech/polkadot#7337Fixes: #1197
TODO