Migrate pallet-mixnet from the deprecated ValidateUnsigned trait to #[pallet::authorize]#11010
Open
RomarQ wants to merge 17 commits intoparitytech:masterfrom
Open
Migrate pallet-mixnet from the deprecated ValidateUnsigned trait to #[pallet::authorize]#11010RomarQ wants to merge 17 commits intoparitytech:masterfrom
pallet-mixnet from the deprecated ValidateUnsigned trait to #[pallet::authorize]#11010RomarQ wants to merge 17 commits intoparitytech:masterfrom
Conversation
This commit migrates pallet-mixnet from the deprecated ValidateUnsigned trait to the modern TransactionExtension API using the #[pallet::authorize] attribute. Changes: - Added TransactionValidityWithRefund import from sp_runtime - Replaced #[pallet::validate_unsigned] implementation with #[pallet::authorize] attribute on the register call - Moved all validation logic into the authorize attribute: * Session index validation (not future/stale) * Authority index bounds checking * Authority ID existence verification * Duplicate registration prevention * Signature verification - Changed ensure_none to ensure_authorized in the register call - Updated debug assertions to reflect validation is now in authorize - Simplified authorize closure using .map() for cleaner code The validation logic and security properties remain identical to the previous implementation, ensuring no behavioral changes while adopting the modern API. This serves as a reference for other authority-based pallets migrating from ValidateUnsigned.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2415 (follow-up to #10150)
Migrate
pallet-mixnetfrom the deprecatedValidateUnsignedtrait to#[pallet::authorize], following the pattern established in #10716.Changes
ValidateUnsignedimpl with#[pallet::authorize]on theregistercall. The validation logic (session index, authority index bounds, authority existence, duplicate registration, signature) is unchanged, just moved inline.CreateBare<Call<Self>>toCreateAuthorizedTransaction<Call<Self>>.ensure_none→ensure_authorized,create_bare→create_authorized_transaction.#[pallet::weight_of_authorize].RawOrigin::Authorized.Migration
The
Configtrait now requiresCreateAuthorizedTransaction<Call<Self>>instead ofCreateBare<Call<Self>>. Runtimes with a blanketimpl<C> CreateAuthorizedTransaction<C> for Runtime(like kitchensink) need no changes.