Skip to content

pallet-revive: Enable call_invalid_opcode test#10849

Merged
marian-radu merged 12 commits intomasterfrom
206-proper-treatment-of-yuls-invalid-in-resolcpvm
Mar 3, 2026
Merged

pallet-revive: Enable call_invalid_opcode test#10849
marian-radu merged 12 commits intomasterfrom
206-proper-treatment-of-yuls-invalid-in-resolcpvm

Conversation

@marian-radu
Copy link
Copy Markdown
Contributor

Fixes paritytech/contract-issues#206

This PR enables the call_invalid_opcode test, which verifies that the INVALID opcode consumes all forwarded gas when executed in a nested call. The underlying issue was fixed in the following PRs:
paritytech/revive#433
#9997

@marian-radu marian-radu added the T7-smart_contracts This PR/Issue is related to smart contracts. label Jan 20, 2026
@marian-radu
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience runtime_dev --bump patch

@0xRVE 0xRVE requested review from a team as code owners January 22, 2026 11:19
@0xRVE 0xRVE force-pushed the 206-proper-treatment-of-yuls-invalid-in-resolcpvm branch from 50aee89 to 1847fdf Compare January 22, 2026 11:20
@0xRVE 0xRVE removed request for a team January 22, 2026 11:24
@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21246597162
Failed job name: test-linux-stable-no-try-runtime

@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21246597162
Failed job name: test-linux-stable

Copy link
Copy Markdown
Contributor

@pgherveou pgherveou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@marian-radu marian-radu requested a review from xermicus January 22, 2026 11:59
@pgherveou
Copy link
Copy Markdown
Contributor

@marian-radu should we merge this?

@marian-radu marian-radu requested a review from a team as a code owner February 26, 2026 10:58
@marian-radu marian-radu requested a review from 0xOmarA February 27, 2026 06:23
@marian-radu marian-radu added this pull request to the merge queue Mar 3, 2026
Merged via the queue into master with commit 9d70d96 Mar 3, 2026
268 of 279 checks passed
@marian-radu marian-radu deleted the 206-proper-treatment-of-yuls-invalid-in-resolcpvm branch March 3, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper treatment of YUL's invalid() in resolc/PVM

3 participants