[stable2512] Backport #10502

[paritytech-release-backport-bot]

Backport #10502 into stable2512 from Ank4n.

NOTE: this PR introduces a breaking change in the signature of the extrinsic set_staking_configs that now has a new extra input parameter: are_nominators_slashable. This is needed to be able to deliver the feature of having non slashable nominator past March 14th. Because of that, we have put validate:false in the related section of the prdoc around pallet-staking-async. Please note that only Root origin can call set_staking_configs so the practical impact of the breaking change is basically zero. We need a Governance referendum to tune the parameters and set nominators as non slashable around March 14th so we need OpenGov to actually use the new version to be able to deliver the requested feature, we can't really avoid that. Adding an extra extrinsic just to avoid the breaking change seems an unnecessary overkill.

See the documentation on how to use this bot.

[paritytech-release-backport-bot]

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10502-to-stable2512
git worktree add --checkout .worktree/backport-10502-to-stable2512 backport-10502-to-stable2512
cd .worktree/backport-10502-to-stable2512
git reset --hard HEAD^
git cherry-pick -x b3bfba618e98f2aa10ee8d4233a15c1e09fef50f
git push --force-with-lease

[github-actions]

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

• Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
• Should be a legit fix for some bug, not adding tons of new features.
• Must either be already audited or not need an audit.

Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21135003136
Failed job name: test-linux-stable

[EgorPopelyaev]

@Ank4n Hey Ankan, can we avoid a major bump of the pallet-staking-async?

[Ank4n]

@Ank4n Hey Ankan, can we avoid a major bump of the pallet-staking-async?

There are new storage and config constants, but we are not really breaking anything. I think that qualifies for minor?
cc: @sigurpol

Updated prdoc.

[Ank4n]

@EgorPopelyaev should I make thee

@Ank4n Hey Ankan, can we avoid a major bump of the pallet-staking-async?

It still complaining about adding this field in extrinsic signature, which unfortunately we can't get rid of and is a breaking change. But we need this in 2512 since we have a deadline to get this live by 14th March.

What do you suggest we do?

cc: @sigurpol

[sigurpol]

@EgorPopelyaev I've added validate: false for pallet-staking-async following:

Emergency Bypass
If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Is it acceptable ? We are fine in creating a new major version of staking-async crate. This change NEEDS to go live on chain before March 14th.

The breaking change is in the change of signature of the extrinsic set_staking_configs that now adds a new extra input parameter: are_nominators_slashable. Please note that only Root origin can call it so the practical impact of the breaking change is basically zero. We need a Governance referendum to tune the parameters and set nominators as non slashable by March 14th so we need OpenGov to actually use the new version to be able to deliver the requested feature, we can't really avoid that. Adding an extra extrinsic just to avoid the breaking change seems an unnecessary overkill.