staking: do not remove an invulnerable in case of bad solution - #10454
Merged
sigurpol merged 3 commits intoNov 28, 2025
Conversation
Invulnerables are not automatically removed from the Invulnerables storage when their solution is rejected. Removal should only happen through governance, not automatically. We consider an operational or network issue much more likely than a bad faith action from an invulnerable.
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
kianenigma
approved these changes
Nov 28, 2025
Ank4n
approved these changes
Nov 28, 2025
sigurpol
deleted the
sigurpol-do-not-remove-invulnerables-bad-solution
branch
November 28, 2025 16:00
bee344
pushed a commit
that referenced
this pull request
Dec 2, 2025
Invulnerables are not automatically removed from the Invulnerables storage when their solution is rejected. Removal should occur only through governance, not automatically. An operational or network issue that leads to an incomplete submission is much more likely than a bad faith action from an invulnerable. Close https://github.com/paritytech-secops/srlabs_findings/issues/602. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/2026-06-30-staking-election-stall-postmortem/18077/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invulnerables are not automatically removed from the Invulnerables storage when their solution is rejected.
Removal should occur only through governance, not automatically.
An operational or network issue that leads to an incomplete submission is much more likely than a bad faith action from an invulnerable.
Close https://github.com/paritytech-secops/srlabs_findings/issues/602.