Skip to content

Accept custom capacity for block notifier buffer #10451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexandruCihodaru merged 6 commits into from
Nov 28, 2025
+12 −0
Merged

Accept custom capacity for block notifier buffer #10451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5becc1c
Accept custom capacity for block notifier buffer
AlexandruCihodaru Nov 28, 2025
f89167b
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Nov 28, 2025
320a0dc
Update from github-actions[bot] running command 'fmt'
github-actions[bot] Nov 28, 2025
45fdcec
feedback v1
AlexandruCihodaru Nov 28, 2025
8a39100
feedback v2
AlexandruCihodaru Nov 28, 2025
64ff8cc
fix prdoc
AlexandruCihodaru Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions prdoc/pr_10451.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
title: Accept custom capacity for block notifier buffer
doc:
- audience: Runtime Dev
description: Add a setter for a custom block notifier
crates:
- name: pallet-revive-eth-rpc
bump: minor
5 changes: 5 additions & 0 deletions substrate/frame/revive/rpc/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,11 @@ impl Client {
self.block_notifier = Some(tokio::sync::broadcast::channel::<H256>(NOTIFIER_CAPACITY).0);
}

/// Sets a block notifier
pub fn set_block_notifier(&mut self, notifier: Option<tokio::sync::broadcast::Sender<H256>>) {
self.block_notifier = notifier;
}

/// Subscribe to past blocks executing the callback for each block in `range`.
async fn subscribe_past_blocks<F, Fut>(
&self,
Expand Down
Loading