Disable polkavm logging in `pallet-revive` by lrubasze · Pull Request #10385 · paritytech/polkadot-sdk

lrubasze · 2025-11-21T10:52:26Z

This PR adds configurable control over PolkaVM logging in pallet-revive to address performance degradation (details: #8760 (comment))

Upgrades PolkaVM to v0.30.0 which provides set_imperfect_logger_filtering_workaround()
Adds pvm_logs flag to DebugSettings to control PolkaVM interpreter logging
Disables PolkaVM logs by default (when pvm_logs=false), enabling them only when explicitly configured
Fixes performance issue where excessive PolkaVM logging was impacting block proposal times

The logging can be re-enabled via debug settings when needed for troubleshooting.

Additionally:

PolkaVM has been bumped globally across whole codebase.

lrubasze · 2025-11-21T10:53:05Z

/cmd prdoc --audience runtime_dev --bump minor

…time_dev --bump minor'

koute

While you're at it can you bump PolkaVM across the whole codebase? It shouldn't be too much trouble.

substrate/frame/revive/src/limits.rs

github-actions · 2025-11-21T11:47:19Z

Differential Tests Results (PolkaVM)

Specified Tests

simple
complex
translated_semantic_tests

Counts

Total Number of Test Cases: 26447
Total Number of Successes: 5789
Total Number of Failures: 72
Total Number of Ignores: 20586

Failures

The test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the --test argument of the framework.

The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information

Detailed Differential Tests Failure Information

Test Specifier	Failure Reason	Note
`complex/create/create2_many/test.json::1::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("ContractTrapped")`
`complex/create/create_in_library/test.json::0::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("")`
`complex/create/create_in_library/test.json::0::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("")`
`complex/create/create_many/test.json::1::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("ContractTrapped")`
`complex/library_call_tuple/test.json::0::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("")`
`complex/library_call_tuple/test.json::0::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("")`
`complex/solidity_by_example/applications/iterable_mapping/test.json::0::Y- >=0.8.1`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("")`
`complex/solidity_by_example/applications/iterable_mapping/test.json::0::Y+ >=0.8.1`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("")`
`simple/function/many_arguments_2.sol::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: CompilerError: Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/simple/function/many_arguments_2.sol:52:40: 52 result = result && main(i, p1, p2, p3, p4, p5, p6, p7, p8, p9, p10, p11, p12, p13, p14, p15, p16, p17, p18, p19, p20) == uint256(i) * i; ^^
`simple/function/many_arguments_2.sol::0::Y+`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: CompilerError: Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/simple/function/many_arguments_2.sol:52:40: 52 result = result && main(i, p1, p2, p3, p4, p5, p6, p7, p8, p9, p10, p11, p12, p13, p14, p15, p16, p17, p18, p19, p20) == uint256(i) * i; ^^
`simple/function/many_arguments_2_complex.sol::0::Y+`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: CompilerError: Stack too deep. Try compiling with `--via-ir` (cli) or the equivalent `viaIR: true` (standard JSON) while enabling the optimizer. Otherwise, try removing local variables. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/simple/function/many_arguments_2_complex.sol:58:21: 58 p1, ^^
`simple/internal_function_pointers/sum_oddness.sol::0::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("ContractTrapped")`	This test case succeeded with other compilation modes: {'Y-'}
`simple/internal_function_pointers/sum_oddness.sol::1::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("ContractTrapped")`	This test case succeeded with other compilation modes: {'Y-'}
`simple/pointer/large_offset.sol::0::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("ContractTrapped")`
`simple/pointer/large_offset.sol::0::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("ContractTrapped")`
`simple/recursion/recursion_keccak.sol::0::Y-`	`Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Failed to parse resolc standard JSON output: failed to parse resolc JSON output: recursion limit exceeded at line 1 column 267625 stderr:`
`simple/recursion/recursion_keccak.sol::0::Y+`	`Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Failed to parse resolc standard JSON output: failed to parse resolc JSON output: recursion limit exceeded at line 1 column 184228 stderr:`
`simple/recursion_keccak.sol::0::Y-`	`Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Failed to parse resolc standard JSON output: failed to parse resolc JSON output: recursion limit exceeded at line 1 column 267555 stderr:`
`simple/recursion_keccak.sol::0::Y+`	`Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Failed to parse resolc standard JSON output: failed to parse resolc JSON output: recursion limit exceeded at line 1 column 184158 stderr:`
`simple/try_catch/unbalanced_gas_limit.sol::0::Y-`	Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0"), CalldataItem("1"), CalldataItem("0"), CalldataItem("0")]) but got 0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001
`simple/try_catch/unbalanced_gas_limit.sol::0::Y+`	Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0"), CalldataItem("1"), CalldataItem("0"), CalldataItem("0")]) but got 0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001
`simple/yul_instructions/blockhash.sol::3::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("$BLOCK_HASH:256")]) but got 0x641f76f95058a29a3795ad51dfd10a19fe5e0090d97640b404413594368010e8`
`simple/yul_instructions/blockhash.sol::3::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("$BLOCK_HASH:256")]) but got 0xa5b64d44c3cc8b6ba224c1b43dce508cccc9e51c10a441bfd238d553009793ed`
`simple/yul_instructions/blockhash.sol::4::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("$BLOCK_HASH:255")]) but got 0x3dfde9221d815c23f5dc76caef3e59bacd80485e055f307ff3a2754b67cf0b08`
`simple/yul_instructions/blockhash.sol::4::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("$BLOCK_HASH:255")]) but got 0x42f06917652b9e70ef002391a9df11316b0da952c4f6d1590cdcf60b0c925624`
`simple/yul_instructions/returndatacopy.sol::41::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/returndatacopy.sol::41::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::5::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::5::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::19::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::19::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::33::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::33::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::47::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::47::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::59::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::59::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::60::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::60::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::61::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::61::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::75::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::75::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::197::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::197::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::200::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::200::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::202::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::202::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::205::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::205::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::207::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::207::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0xdeadbeef")]) but got 0x0000000000000000000000000000000000000000000000000000000000000000`
`simple/yul_instructions/revert.sol::210::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`simple/yul_instructions/revert.sol::210::Y+`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`translated_semantic_tests/array/copying/array_nested_calldata_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying nested calldata dynamic arrays to storage is not implemented in the old code generator. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/array_nested_calldata_to_storage/array_nested_calldata_to_storage.sol:2:1: 2 contract c { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/array_of_struct_calldata_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S calldata[] calldata to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/array_of_struct_calldata_to_storage/array_of_struct_calldata_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/array_of_struct_memory_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S memory[] memory to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/array_of_struct_memory_to_storage/array_of_struct_memory_to_storage.sol:1:1: 1 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/array_of_structs_containing_arrays_calldata_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S calldata[] calldata to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/array_of_structs_containing_arrays_calldata_to_storage/array_of_structs_containing_arrays_calldata_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/array_of_structs_containing_arrays_memory_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S memory[] memory to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/array_of_structs_containing_arrays_memory_to_storage/array_of_structs_containing_arrays_memory_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/calldata_array_to_mapping/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying nested calldata dynamic arrays to storage is not implemented in the old code generator. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/calldata_array_to_mapping/calldata_array_to_mapping.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/elements_of_nested_array_of_structs_calldata_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying nested calldata dynamic arrays to storage is not implemented in the old code generator. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/elements_of_nested_array_of_structs_calldata_to_storage/elements_of_nested_array_of_structs_calldata_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/elements_of_nested_array_of_structs_memory_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S memory[1] memory to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/elements_of_nested_array_of_structs_memory_to_storage/elements_of_nested_array_of_structs_memory_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/nested_array_of_structs_calldata_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying nested calldata dynamic arrays to storage is not implemented in the old code generator. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/nested_array_of_structs_calldata_to_storage/nested_array_of_structs_calldata_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/nested_array_of_structs_memory_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S memory[] memory to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/nested_array_of_structs_memory_to_storage/nested_array_of_structs_memory_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/nested_array_of_structs_storage_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S memory[1] memory to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/nested_array_of_structs_storage_to_storage/nested_array_of_structs_storage_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/nested_array_of_structs_with_nested_array_from_storage_to_memory/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying of type struct C.S memory[] memory to storage is not supported in legacy (only supported by the IR pipeline). Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON) --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/nested_array_of_structs_with_nested_array_from_storage_to_memory/nested_array_of_structs_with_nested_array_from_storage_to_memory.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/copying/nested_dynamic_array_element_calldata_to_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying nested calldata dynamic arrays to storage is not implemented in the old code generator. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/copying/nested_dynamic_array_element_calldata_to_storage/nested_dynamic_array_element_calldata_to_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/nested_calldata_storage/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying nested calldata dynamic arrays to storage is not implemented in the old code generator. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/nested_calldata_storage/nested_calldata_storage.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/array/nested_calldata_storage2/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: UnimplementedFeatureError: Copying nested calldata dynamic arrays to storage is not implemented in the old code generator. --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/array/nested_calldata_storage2/nested_calldata_storage2.sol:2:1: 2 contract C { ^ (Relevant source part starts here and spans across multiple lines).
`translated_semantic_tests/saltedCreate/prediction_example/test.json::0::Y-`	`Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("revert: Address mismatch.")`
`translated_semantic_tests/shanghai/evmone_support/test.json::0::Y-`	Failed to create the drivers for the various platforms: Failed to create driver for revive-dev-node-polkavm-resolc: Failed to initialize the execution state of the platform: Failed to produce the pre-linking compiled contracts: Compilation callback failed (cache miss path): Encountered an error in the compilation: Error: LLVM IR generator: 306:17 The `EXTCODECOPY` instruction is not supported --> /__w/polkadot-sdk/polkadot-sdk/revive-differential-tests/resolc-compiler-tests/fixtures/solidity/translated_semantic_tests/shanghai/evmone_support/evmone_support.sol

github-actions · 2025-11-21T11:47:44Z

Differential Tests Results (REVM)

Specified Tests

simple
complex
translated_semantic_tests

Counts

Total Number of Test Cases: 26447
Total Number of Successes: 19171
Total Number of Failures: 9
Total Number of Ignores: 7267

Failures

The test specifiers seen in this section have the format 'path::case_idx::compilation_mode' and they're compatible with the revive differential tests framework and can be specified to it directly in the same way that they're provided through the --test argument of the framework.

The failures are provided in an expandable section to ensure that the PR does not get polluted with information. Please click on the section below for more information

Detailed Differential Tests Failure Information

Test Specifier	Failure Reason	Note
`simple/try_catch/unbalanced_gas_limit.sol::0::Y+`	Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0"), CalldataItem("1"), CalldataItem("0"), CalldataItem("0")]) but got 0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001
`simple/try_catch/unbalanced_gas_limit.sol::0::E-`	Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0"), CalldataItem("1"), CalldataItem("0"), CalldataItem("0")]) but got 0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001
`simple/try_catch/unbalanced_gas_limit.sol::0::Y-`	Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0"), CalldataItem("1"), CalldataItem("0"), CalldataItem("0")]) but got 0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001
`simple/try_catch/unbalanced_gas_limit.sol::0::E+`	Failed to execute all of the steps on the driver: Failure on step 0: Function call step Failed: Failed to handle function call assertions: Output assertion failed - Expected Compound([CalldataItem("0"), CalldataItem("1"), CalldataItem("0"), CalldataItem("0")]) but got 0x0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001
`translated_semantic_tests/array/array_storage_index_access/test.json::0::E-`	`Failed to execute all of the steps on the driver: Failure on step 6: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`translated_semantic_tests/array/array_storage_length_access/test.json::0::E-`	`Failed to execute all of the steps on the driver: Failure on step 5: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`translated_semantic_tests/array/array_storage_push_empty_length_address/test.json::0::E-`	`Failed to execute all of the steps on the driver: Failure on step 6: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`translated_semantic_tests/array/array_storage_push_pop/test.json::0::E-`	`Failed to execute all of the steps on the driver: Failure on step 5: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected true but got false. Revert reason: Some("OutOfGas")`
`translated_semantic_tests/functionCall/gas_and_value_basic/test.json::0::E-`	`Failed to execute all of the steps on the driver: Failure on step 2: Function call step Failed: Failed to handle function call assertions: Transaction status assertion failed - Expected false but got true. Revert reason: None`

xermicus

Do I get it right: This disables the interpreter logs in all runtimes? And we don't yet have any other method for debugging PVM contracts. If I'm not missing something can we add this as a const bool to Config instead?

lrubasze · 2025-11-21T13:59:48Z

Do I get it right: This disables the interpreter logs in all runtimes? And we don't yet have any other method for debugging PVM contracts. If I'm not missing something can we add this as a const bool to Config instead?

@xermicus do you think we can use already existing DebugEnabled constant?

polkadot-sdk/substrate/frame/revive/src/lib.rs

Line 339 in f1e9b3a

type DebugEnabled: Get<bool>;

xermicus · 2025-11-21T14:44:04Z

Not sure what's preferred here - adding a pvm_logs field to the DebugSettings struct may also be a clean way to do it.

(Not sure why those are not just const bools but are in storage instead - but I guess at least we get some consistency by adding it there)

lrubasze · 2025-11-21T15:30:28Z

@athei @pgherveou WDYT? What option do you prefer?

lrubasze · 2025-11-24T13:43:33Z

/cmd prdoc --audience runtime_dev --bump minor

lrubasze · 2025-11-24T13:43:50Z

Not sure what's preferred here - adding a pvm_logs field to the DebugSettings struct may also be a clean way to do it.

(Not sure why those are not just const bools but are in storage instead - but I guess at least we get some consistency by adding it there)

@xermicus done

github-actions · 2025-11-24T13:45:57Z

Command "prdoc --audience runtime_dev --bump minor" has failed ❌! See logs here

lrubasze · 2025-11-24T13:53:33Z

/cmd prdoc --audience runtime_dev --bump major --force

…time_dev --bump major --force'

…lkavm-logging

substrate/frame/revive/src/limits.rs

substrate/frame/revive/fixtures/build.rs

substrate/frame/revive/src/tests/pvm.rs

…lkavm-logging

paritytech-workflow-stopper · 2025-11-25T11:18:39Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/19667463352
Failed job name: test-linux-stable-runtime-benchmarks

This PR adds configurable control over PolkaVM logging in `pallet-revive` to address performance degradation (details: #8760 (comment)) - Upgrades PolkaVM to v0.30.0 which provides `set_imperfect_logger_filtering_workaround()` - Adds `pvm_logs` flag to `DebugSettings` to control PolkaVM interpreter logging - Disables PolkaVM logs by default (when `pvm_logs=false`), enabling them only when explicitly configured - Fixes performance issue where excessive PolkaVM logging was impacting block proposal times The logging can be re-enabled via debug settings when needed for troubleshooting. Additionally: - PolkaVM has been bumped globally across whole codebase. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Backport all pallet-revive related changes into `unstable2507`. These are all the changes we want to get onto the next Kusama release. Main changes include - EVM backend - Ethereum block storage - Generalized gas mapping The complete list of PRs in this backport is - #9482 - #9455 - #9454 - #9501 - #9177 - #9285 - #9606 - #9414 - #9557 - #9617 - #9385 - #9679 - #9705 - #9561 - #9744 - #9736 - #9701 - #9517 - #9771 - #9683 - #9791 - #9717 - #9759 - #9823 - #9768 - #9853 - #9801 - #9780 - #9796 - #9878 - #9841 - #9670 - #9865 - #9803 - #9928 - #9818 - #9911 - #9942 - #9831 - #9945 - #9603 - #9968 - #9939 - #9991 - #9914 - #9997 - #9985 - #10016 - #10027 - #10026 - #9418 - #9988 - #10041 - #10047 - #10032 - #10065 - #10089 - #10080 - #10090 - #10106 - #10020 - #9512 - #10109 - #9699 - #10100 - #9909 - #10120 - #10146 - #10157 - #10168 - #10169 - #10160 - #10129 - #10175 - #10186 - #10192 - #10148 - #10193 - #10220 - #10233 - #10191 - #10225 - #10246 - #10239 - #10159 - #10252 - #10224 - #10267 - #10271 - #10214 - #10297 - #10290 - #10281 - #10272 - #10303 - #10336 - #10244 - #10366 - #10380 - #10383 - #10387 - #10302 - #10309 - #10427 - #10385 - #10451 - #10471 - #10166 - #10510 - #10393 - #10540 - #9587 - #10071 - #10558 - #10554 - #10325 --------- Signed-off-by: xermicus <cyrill@parity.io> Co-authored-by: Pavlo Khrystenko <45178695+pkhry@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: pgherveou <pgherveou@gmail.com> Co-authored-by: Omar <OmarAbdulla7@hotmail.com> Co-authored-by: 0xRVE <robertvaneerdewijk@gmail.com> Co-authored-by: xermicus <cyrill@parity.io> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

lrubasze added 3 commits November 21, 2025 11:45

revive: bump polkavm

ab5c0d6

revive: align to updated polkavm

56d2af4

revive: disable polkavm logging

53ec86b

lrubasze added the T7-smart_contracts This PR/Issue is related to smart contracts. label Nov 21, 2025

Update from github-actions[bot] running command 'prdoc --audience run…

2deab42

…time_dev --bump minor'

lrubasze requested review from alexggh, athei, koute, pgherveou and xermicus November 21, 2025 10:56

lrubasze mentioned this pull request Nov 21, 2025

enabling any debug level, doubles block proposing time #8760

Closed

koute reviewed Nov 21, 2025

View reviewed changes

substrate/frame/revive/src/limits.rs Show resolved Hide resolved

lrubasze added 2 commits November 21, 2025 12:32

revive: use instructions_with_isa

fa32f59

revive: updates call_builder

f1e9b3a

pgherveou approved these changes Nov 21, 2025

View reviewed changes

xermicus reviewed Nov 21, 2025

View reviewed changes

lrubasze added 2 commits November 24, 2025 13:59

bump polkavm globally

42c84c1

revive: Add pvm_logs flag to DebugSettings

b6e3343

github-actions bot and others added 2 commits November 24, 2025 13:56

Update from github-actions[bot] running command 'prdoc --audience run…

cf29625

…time_dev --bump major --force'

fix prdoc

8d84b6a

Merge remote-tracking branch 'origin/master' into lrubasze/disable-po…

370a3df

…lkavm-logging

koute reviewed Nov 24, 2025

View reviewed changes

substrate/frame/revive/src/limits.rs Outdated Show resolved Hide resolved

substrate/frame/revive/src/limits.rs Outdated Show resolved Hide resolved

substrate/frame/revive/fixtures/build.rs Outdated Show resolved Hide resolved

lrubasze added 3 commits November 24, 2025 17:13

pallet-revive: Use PVM Revive instructions

3d02063

pallet-revive: refactor sbrk test

b1fdac9

pallet-revive-fixtures: cleanup

a8fe524

lrubasze commented Nov 24, 2025

View reviewed changes

substrate/frame/revive/src/tests/pvm.rs Show resolved Hide resolved

lrubasze added 5 commits November 24, 2025 22:51

pallet-revive-fixtures: cleanup 2

8b987c6

fix prdoc

e2acf38

Merge remote-tracking branch 'origin/master' into lrubasze/disable-po…

23480ed

…lkavm-logging

pallet-revive-fixtures: cleanup after merging master

4b2689e

pallet-revive-fixtures: clippy

d3d1104

lrubasze added 4 commits November 25, 2025 12:40

fix build

c1f3190

fix prdoc

be83ba2

fix prdoc

fd2c14e

fix prdoc

50ea4d2

koute approved these changes Nov 26, 2025

View reviewed changes

xermicus approved these changes Nov 26, 2025

View reviewed changes

lrubasze added 3 commits November 26, 2025 11:38

Merge branch 'master' into lrubasze/disable-polkavm-logging

4a4bf41

pallet-revive-fixtures: bump polkavm in _Cargo.toml template

519114e

pallet-revive: add some comment

c0bd94e

lrubasze added this pull request to the merge queue Nov 26, 2025

Merged via the queue into master with commit 08a4a54 Nov 26, 2025
253 of 260 checks passed

lrubasze deleted the lrubasze/disable-polkavm-logging branch November 26, 2025 15:34

koute mentioned this pull request Nov 27, 2025

Failed to run "cargo build --release --features runtime-benchmarks" #10400

Closed

TorstenStueber mentioned this pull request Dec 5, 2025

[unstable2507] Pallet-revive changes #10552

Merged

Conversation

lrubasze commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lrubasze commented Nov 21, 2025

Uh oh!

koute left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Differential Tests Results (PolkaVM)

Specified Tests

Counts

Failures

Uh oh!

github-actions bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Differential Tests Results (REVM)

Specified Tests

Counts

Failures

Uh oh!

xermicus left a comment

Choose a reason for hiding this comment

Uh oh!

lrubasze commented Nov 21, 2025

Uh oh!

xermicus commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lrubasze commented Nov 21, 2025

Uh oh!

lrubasze commented Nov 24, 2025

Uh oh!

lrubasze commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025

Uh oh!

lrubasze commented Nov 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paritytech-workflow-stopper bot commented Nov 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lrubasze commented Nov 21, 2025 •

edited

Loading

github-actions bot commented Nov 21, 2025 •

edited

Loading

github-actions bot commented Nov 21, 2025 •

edited

Loading

xermicus commented Nov 21, 2025 •

edited

Loading