ClaimQueueState cosmetics#10334
Merged
tdimitrov merged 6 commits intoparitytech:alindima/collator-protocol-revamp-collation-managerfrom Nov 19, 2025
Merged
Conversation
alindima
approved these changes
Nov 19, 2025
polkadot/node/network/collator-protocol/src/validator_side/claim_queue_state.rs
Outdated
Show resolved
Hide resolved
tdimitrov
approved these changes
Nov 19, 2025
| } | ||
| } | ||
|
|
||
| fn clone_or_default(&self, known_candidates: &HashSet<CandidateHash>) -> Self { |
| hash: None, | ||
| claim: c.claim, | ||
| claim_queue_len: 1, | ||
| claimed: c.claimed.clone_or_default(&candidates_in_view), |
polkadot/node/network/collator-protocol/src/validator_side/claim_queue_state.rs
Show resolved
Hide resolved
tdimitrov
merged commit 7abb6f3
into
paritytech:alindima/collator-protocol-revamp-collation-manager
169 of 177 checks passed
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Implements the `CollationManager` and the new collator protocol (validator side) subsystem. Issues #8182 and #7752. These are the big remaining parts which would enable us to test the entire implementation. TODO: - [ ] add a couple more unit tests (see the suggestions at the bottom of the tests file) - [x] polish the ClaimQueueState and verify if it's sufficiently covered by unit tests - #10334 - #10368 - [x] add metrics and polish logs - #10730 - [x] add a CLI parameter for enabling the experimental subsystem (and remove the compile-time feature) -> #10285 - [x] implement registered paras update, using #9055 - [ ] do some manual zombienet tests with v1 protocol version and with restarting validators (including syncing with warp sync) - [x] prdoc - [x] Rollback - 03e8915 - 05e1497 These commits were added just to run the CI tests for this PR with the new experimental protocol After merging: - [ ] versi testing Uses a slightly modified version of the ClaimQueueState written by @tdimitrov in #7114. --------- Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: Serban Iorga <serban300@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only some cosmetics and deduplications