revive: Fix dust & child contract calls

prdoc/pr_10192.prdoc

@@ -0,0 +1,21 @@
+title: 'revive: Fix dust & child contract calls'
+doc:
+- audience: Runtime Dev
+  description: |-
+    When transferring to self we should just return early as it's a noop.
+    Not doing so cause bug in `transfer_with_dust`
+
+    as we do
+    ```
+    from.dust -= from.dust
+    to.dust += to.dust
+    ```
+
+    We end up with a value of dust - planck (that we burnt from to create dust amount) on the account
+
+    fix https://github.com/paritytech/contract-issues/issues/211
+crates:
+- name: pallet-revive-fixtures
+  bump: patch
+- name: pallet-revive
+  bump: patch

substrate/frame/revive/fixtures/contracts/call_self_with_dust.sol

@@ -0,0 +1,7 @@
+contract CallSelfWithDust {
+    function f() external payable {}
+
+    function call() public payable {
+        this.f{value: 10}();
+    }
+}

substrate/frame/revive/src/exec.rs

@@ -1521,6 +1521,10 @@ where
 		storage_meter: &mut storage::meter::GenericMeter<T, S>,
 		exec_config: &ExecConfig<T>,
 	) -> DispatchResult {
+		if from == to || value.is_zero() {
+			return Ok(())
+		}
+
 		fn transfer_with_dust<T: Config>(
 			from: &AccountIdOf<T>,
 			to: &AccountIdOf<T>,

substrate/frame/revive/src/tests/sol.rs

@@ -240,3 +240,26 @@ fn upload_evm_runtime_code_works() {
 		assert_eq!(55u64, decoded, "Contract should correctly compute fibonacci(10)");
 	});
 }
+
+#[test]
+fn dust_work_with_child_calls() {
+	use pallet_revive_fixtures::CallSelfWithDust;
+	let (code, _) = compile_module_with_type("CallSelfWithDust", FixtureType::Solc).unwrap();
+
+	ExtBuilder::default().build().execute_with(|| {
+		let _ = <Test as Config>::Currency::set_balance(&ALICE, 100_000_000_000);
+		let Contract { addr, .. } =
+			builder::bare_instantiate(Code::Upload(code.clone())).build_and_unwrap_contract();
+
+		let value = 1_000_000_000.into();
+		builder::bare_call(addr)
+			.data(
+				CallSelfWithDust::CallSelfWithDustCalls::call(CallSelfWithDust::callCall {})
+					.abi_encode(),
+			)
+			.evm_value(value)
+			.build_and_unwrap_result();
+
+		assert_eq!(crate::Pallet::<Test>::evm_balance(&addr), value);
+	});
+}