Deprecate ValidateUnsigned trait and #[pallet::validate_unsigned] attribute

polkadot/runtime/common/src/claims/benchmarking.rs

@@ -26,10 +26,7 @@ use frame_support::{
 };
 use frame_system::RawOrigin;
 use secp_utils::*;
-use sp_runtime::{
-	traits::{DispatchTransaction, ValidateUnsigned},
-	DispatchResult,
-};
+use sp_runtime::{traits::DispatchTransaction, DispatchResult};
 
 const SEED: u32 = 0;
 
@@ -74,6 +71,9 @@ fn create_claim_attest<T: Config>(input: u32) -> DispatchResult {
 mod benchmarks {
 	use super::*;
 
+	#[allow(deprecated)]
+	use sp_runtime::traits::ValidateUnsigned;
+
 	// Benchmark `claim` including `validate_unsigned` logic.
 	#[benchmark]
 	fn claim() -> Result<(), BenchmarkError> {
@@ -104,6 +104,7 @@ mod benchmarks {
 		{
 			let call = <Call<T> as Decode>::decode(&mut &*call_enc)
 				.expect("call is encoded above, encoding must be correct");
+			#[allow(deprecated)]
 			super::Pallet::<T>::validate_unsigned(source, &call)
 				.map_err(|e| -> &'static str { e.into() })?;
 			call.dispatch_bypass_filter(RawOrigin::None.into())?;
@@ -168,6 +169,7 @@ mod benchmarks {
 		{
 			let call = <Call<T> as Decode>::decode(&mut &*call_enc)
 				.expect("call is encoded above, encoding must be correct");
+			#[allow(deprecated)]
 			super::Pallet::<T>::validate_unsigned(source, &call)
 				.map_err(|e| -> &'static str { e.into() })?;
 			call.dispatch_bypass_filter(RawOrigin::None.into())?;

polkadot/runtime/common/src/claims/mod.rs

@@ -494,6 +494,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

polkadot/runtime/common/src/claims/tests.rs

@@ -564,6 +564,7 @@ fn real_eth_sig_works() {
 }
 
 #[test]
+#[allow(deprecated)]
 fn validate_unsigned_works() {
 	use sp_runtime::traits::ValidateUnsigned;
 	let source = sp_runtime::transaction_validity::TransactionSource::External;

polkadot/runtime/parachains/src/disputes/slashing.rs

@@ -530,6 +530,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

polkadot/runtime/parachains/src/paras/mod.rs

@@ -1365,6 +1365,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

polkadot/runtime/parachains/src/paras/tests.rs

@@ -1457,6 +1457,7 @@ fn pvf_check_submit_vote() {
 
 		let call =
 			Call::include_pvf_check_statement { stmt: stmt.clone(), signature: signature.clone() };
+		#[allow(deprecated)]
 		let validate_unsigned =
 			<Paras as ValidateUnsigned>::validate_unsigned(TransactionSource::InBlock, &call)
 				.map(|_| ());
@@ -2263,6 +2264,7 @@ fn apply_authorized_force_set_current_code_works() {
 	                  code: ValidationCode|
 	 -> (Result<_, _>, DispatchResultWithPostInfo) {
 		let call = Call::apply_authorized_force_set_current_code { para, new_code: code.clone() };
+		#[allow(deprecated)]
 		let validate_unsigned =
 			<Paras as ValidateUnsigned>::validate_unsigned(TransactionSource::InBlock, &call)
 				.map(|_| ());

prdoc/pr_10150.prdoc

@@ -0,0 +1,38 @@
+title: Deprecate `ValidateUnsigned` trait and `#[pallet::validate_unsigned]` attribute.
+
+doc:
+  - audience: [Runtime Dev, Runtime User]
+    description: |
+      Deprecate the `ValidateUnsigned` trait and `#[pallet::validate_unsigned]` attribute as part of phase 2 of Extrinsic Horizon.
+
+crates:
+  - name: sp-runtime
+    bump: minor
+  - name: frame-system
+    bump: patch
+  - name: frame-support
+    bump: patch
+  - name: frame-support-procedural
+    bump: minor
+  - name: polkadot-runtime-common
+    bump: patch
+  - name: polkadot-runtime-parachains
+    bump: patch
+  - name: pallet-babe
+    bump: patch
+  - name: pallet-beefy
+    bump: patch
+  - name: pallet-election-provider-multi-phase
+    bump: patch
+  - name: pallet-election-provider-multi-block
+    bump: patch
+  - name: frame-executive
+    bump: patch
+  - name: pallet-grandpa
+    bump: patch
+  - name: pallet-im-online
+    bump: patch
+  - name: pallet-mixnet
+    bump: patch
+  - name: substrate-test-runtime
+    bump: patch

substrate/frame/babe/src/lib.rs

@@ -471,6 +471,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/babe/src/tests.rs

@@ -729,6 +729,7 @@ fn report_equivocation_invalid_equivocation_proof() {
 }
 
 #[test]
+#[allow(deprecated)]
 fn report_equivocation_validate_unsigned_prevents_duplicates() {
 	use sp_runtime::transaction_validity::{
 		InvalidTransaction, TransactionPriority, TransactionSource, TransactionValidity,

substrate/frame/beefy/src/lib.rs

@@ -423,6 +423,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/beefy/src/tests.rs

@@ -730,6 +730,7 @@ fn report_double_voting_invalid_equivocation_proof() {
 }
 
 #[test]
+#[allow(deprecated)]
 fn report_double_voting_validate_unsigned_prevents_duplicates() {
 	use sp_runtime::transaction_validity::{
 		InvalidTransaction, TransactionPriority, TransactionSource, TransactionValidity,

substrate/frame/election-provider-multi-block/src/lib.rs

@@ -2751,9 +2751,7 @@ mod election_provider {
 		Phase,
 	};
 	use frame_election_provider_support::{BoundedSupport, BoundedSupports, ElectionProvider};
-	use frame_support::{
-		assert_storage_noop, testing_prelude::bounded_vec, unsigned::ValidateUnsigned,
-	};
+	use frame_support::{assert_storage_noop, testing_prelude::bounded_vec};
 
 	// This is probably the most important test of all, a basic, correct scenario. This test should
 	// be studied in detail, and all of the branches of how it can go wrong or diverge from the
@@ -3057,7 +3055,9 @@ mod election_provider {
 	}
 
 	#[test]
+	#[allow(deprecated)]
 	fn call_to_elect_should_prevent_any_submission() {
+		use frame_support::unsigned::ValidateUnsigned;
 		ExtBuilder::full().build_and_execute(|| {
 			roll_to_signed_open();
 			assert!(MultiBlock::current_phase().is_signed());

substrate/frame/election-provider-multi-block/src/unsigned/benchmarking.rs

@@ -45,7 +45,9 @@ mod benchmarks {
 
 		#[block]
 		{
-			assert_ok!(Pallet::<T>::validate_unsigned(TransactionSource::Local, &call));
+			#[allow(deprecated)]
+			let result = Pallet::<T>::validate_unsigned(TransactionSource::Local, &call);
+			assert_ok!(result);
 		}
 
 		Ok(())

substrate/frame/election-provider-multi-block/src/unsigned/mod.rs

@@ -180,6 +180,7 @@ mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;
@@ -370,6 +371,7 @@ mod pallet {
 }
 
 #[cfg(test)]
+#[allow(deprecated)]
 mod validate_unsigned {
 	use frame_election_provider_support::Support;
 	use frame_support::{

substrate/frame/election-provider-multi-phase/src/lib.rs

@@ -1214,6 +1214,7 @@ pub mod pallet {
 		PreDispatchDifferentRound,
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/election-provider-multi-phase/src/unsigned.rs

@@ -1108,13 +1108,17 @@ mod tests {
 	use sp_runtime::{
 		bounded_vec,
 		offchain::storage_lock::{BlockAndTime, StorageLock},
-		traits::{Dispatchable, ValidateUnsigned, Zero},
+		traits::{Dispatchable, Zero},
 		ModuleError, PerU16,
 	};
 
+	#[allow(deprecated)]
+	use sp_runtime::traits::ValidateUnsigned;
+
 	type Assignment = crate::unsigned::Assignment<Runtime>;
 
 	#[test]
+	#[allow(deprecated)]
 	fn validate_unsigned_retracts_wrong_phase() {
 		ExtBuilder::default().desired_targets(0).build_and_execute(|| {
 			let solution = RawSolution::<TestNposSolution> {
@@ -1187,6 +1191,7 @@ mod tests {
 	}
 
 	#[test]
+	#[allow(deprecated)]
 	fn validate_unsigned_retracts_low_score() {
 		ExtBuilder::default().desired_targets(0).build_and_execute(|| {
 			roll_to_unsigned();
@@ -1233,6 +1238,7 @@ mod tests {
 	}
 
 	#[test]
+	#[allow(deprecated)]
 	fn validate_unsigned_retracts_incorrect_winner_count() {
 		ExtBuilder::default().desired_targets(1).build_and_execute(|| {
 			roll_to_unsigned();
@@ -1259,6 +1265,7 @@ mod tests {
 	}
 
 	#[test]
+	#[allow(deprecated)]
 	fn priority_is_set() {
 		ExtBuilder::default()
 			.miner_tx_priority(20)
@@ -1904,6 +1911,7 @@ mod tests {
 	}
 
 	#[test]
+	#[allow(deprecated)]
 	fn ocw_solution_must_have_correct_round() {
 		let (mut ext, pool) = ExtBuilder::default().build_offchainify(0);
 		ext.execute_with(|| {

substrate/frame/examples/offchain-worker/src/lib.rs

@@ -305,6 +305,7 @@ pub mod pallet {
 		NewPrice { price: u32, maybe_who: Option<T::AccountId> },
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/executive/src/lib.rs

@@ -68,14 +68,6 @@
 //! # use sp_runtime::transaction_validity::{
 //! #    TransactionValidity, UnknownTransaction, TransactionSource,
 //! # };
-//! # use sp_runtime::traits::ValidateUnsigned;
-//! # impl ValidateUnsigned for Runtime {
-//! #     type Call = ();
-//! #
-//! #     fn validate_unsigned(_source: TransactionSource, _call: &Self::Call) -> TransactionValidity {
-//! #         UnknownTransaction::NoUnsignedValidator.into()
-//! #     }
-//! # }
 //! /// Executive: handles dispatch to the various modules.
 //! pub type Executive = executive::Executive<Runtime, Block, Context, Runtime, AllPalletsWithSystem>;
 //! ```
@@ -135,12 +127,15 @@ use sp_runtime::{
 	generic::Digest,
 	traits::{
 		self, Applyable, CheckEqual, Checkable, Dispatchable, Header, LazyBlock, NumberFor, One,
-		ValidateUnsigned, Zero,
+		Zero,
 	},
 	transaction_validity::{TransactionSource, TransactionValidity, TransactionValidityError},
 	ApplyExtrinsicResult, ExtrinsicInclusionMode,
 };
 
+#[allow(deprecated)]
+use sp_runtime::traits::ValidateUnsigned;
+
 #[cfg(feature = "try-runtime")]
 use ::{
 	frame_support::{

substrate/frame/executive/src/tests.rs

@@ -139,6 +139,7 @@ mod custom {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;
@@ -261,6 +262,7 @@ mod custom2 {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/grandpa/src/lib.rs

@@ -359,6 +359,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/grandpa/src/tests.rs

@@ -661,6 +661,7 @@ fn report_equivocation_invalid_equivocation_proof() {
 }
 
 #[test]
+#[allow(deprecated)]
 fn report_equivocation_validate_unsigned_prevents_duplicates() {
 	use sp_runtime::transaction_validity::{
 		InvalidTransaction, TransactionPriority, TransactionSource, TransactionValidity,

substrate/frame/im-online/src/benchmarking.rs

@@ -22,10 +22,7 @@
 use frame_benchmarking::v2::*;
 use frame_support::{traits::UnfilteredDispatchable, WeakBoundedVec};
 use frame_system::RawOrigin;
-use sp_runtime::{
-	traits::{ValidateUnsigned, Zero},
-	transaction_validity::TransactionSource,
-};
+use sp_runtime::{traits::Zero, transaction_validity::TransactionSource};
 
 use crate::*;
 
@@ -83,6 +80,7 @@ mod benchmarks {
 
 		#[block]
 		{
+			#[allow(deprecated)]
 			Pallet::<T>::validate_unsigned(TransactionSource::InBlock, &call)
 				.map_err(<&str>::from)?;
 		}
@@ -100,6 +98,7 @@ mod benchmarks {
 
 		#[block]
 		{
+			#[allow(deprecated)]
 			Pallet::<T>::validate_unsigned(TransactionSource::InBlock, &call)
 				.map_err(<&str>::from)?;
 			<Call<T> as Decode>::decode(&mut &*call_enc)

substrate/frame/im-online/src/lib.rs

@@ -447,6 +447,7 @@ pub mod pallet {
 	/// incorrect.
 	pub(crate) const INVALID_VALIDATORS_LEN: u8 = 10;
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/im-online/src/tests.rs

@@ -120,6 +120,7 @@ fn heartbeat(
 	};
 	let signature = id.sign(&heartbeat.encode()).unwrap();
 
+	#[allow(deprecated)]
 	ImOnline::pre_dispatch(&crate::Call::heartbeat {
 		heartbeat: heartbeat.clone(),
 		signature: signature.clone(),

substrate/frame/mixnet/src/lib.rs

@@ -303,6 +303,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;

substrate/frame/sassafras/src/lib.rs

@@ -463,6 +463,7 @@ pub mod pallet {
 		}
 	}
 
+	#[allow(deprecated)]
 	#[pallet::validate_unsigned]
 	impl<T: Config> ValidateUnsigned for Pallet<T> {
 		type Call = Call<T>;