revive/fix: Remove double tax on eth_call weight#10125
Closed
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
|
let me do that as part of #10120 |
Contributor
|
will port the patch here #10120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the
eth_callwitheth_instantiate_with_codein terms of weight.@pgherveou noticed that we are double taxing the
eth_callin terms of weight:#pallet::weighton the encoded tx length.saturating_add(T::WeightInfo::on_finalize_block_per_tx(encoded_length))This PR removes the weight from (II) and relies on the
#pallet::weightentirely.cc @pgherveou @lrubasze 🙏