Skip to content

revive/fix: Remove double tax on eth_call weight#10125

Closed
lexnv wants to merge 2 commits intomasterfrom
lexnv/revive-fix-weights
Closed

revive/fix: Remove double tax on eth_call weight#10125
lexnv wants to merge 2 commits intomasterfrom
lexnv/revive-fix-weights

Conversation

@lexnv
Copy link
Copy Markdown
Contributor

@lexnv lexnv commented Oct 27, 2025

This PR aligns the eth_call with eth_instantiate_with_code in terms of weight.

@pgherveou noticed that we are double taxing the eth_call in terms of weight:

  • (I) we are adding the #pallet::weight on the encoded tx length
  • (II) we are adding the same weight again via .saturating_add(T::WeightInfo::on_finalize_block_per_tx(encoded_length))

This PR removes the weight from (II) and relies on the #pallet::weight entirely.

cc @pgherveou @lrubasze 🙏

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this Oct 27, 2025
@lexnv lexnv added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 27, 2025
@lexnv
Copy link
Copy Markdown
Contributor Author

lexnv commented Oct 27, 2025

/cmd prdoc --audience node_dev --bump patch

@paritytech-workflow-stopper
Copy link
Copy Markdown

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/18845187888
Failed job name: test-linux-stable

Copy link
Copy Markdown
Contributor

@lrubasze lrubasze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgherveou
Copy link
Copy Markdown
Contributor

let me do that as part of #10120
I think we also need update the eth_instantiate_with_code weight attribute

@pgherveou
Copy link
Copy Markdown
Contributor

will port the patch here #10120

@pgherveou pgherveou closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants