Skip to content

Enforce single-state txpool for revive-dev-node #10106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pgherveou merged 3 commits into from
Oct 23, 2025
Merged

Enforce single-state txpool for revive-dev-node #10106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
658d377
Enforce single-state txpool for revive-dev-node with instant-seal
pgherveou Oct 23, 2025
768cd5d
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Oct 23, 2025
95632d4
Merge branch 'master' into pg/enforce-single-state-tx-pool
pgherveou Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions prdoc/pr_10106.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
title: Enforce single-state txpool for revive-dev-node
doc:
- audience: Runtime Dev
description: |-
Use single-state txpool for dev-node when instant-seal is selected

see https://github.com/paritytech/polkadot-sdk/issues/10104
crates: []
6 changes: 5 additions & 1 deletion substrate/frame/revive/dev-node/node/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ pub fn run() -> sc_cli::Result<()> {
}
}

let cli = Cli::from_iter(args);
let mut cli = Cli::from_iter(args);

match &cli.subcommand {
Some(Subcommand::Key(cmd)) => cmd.run(&cli),
Expand Down Expand Up @@ -121,6 +121,10 @@ pub fn run() -> sc_cli::Result<()> {
runner.sync_run(|config| cmd.run::<revive_dev_runtime::OpaqueBlock>(&config))
},
None => {
// Enforce single-state pool-type if instant-seal is selected
if matches!(cli.consensus, crate::cli::Consensus::InstantSeal) {
cli.run.pool_config.pool_type = sc_cli::TransactionPoolType::SingleState
}
let runner = cli.create_runner(&cli.run)?;
runner.run_node_until_exit(|config| async move {
match config.network.network_backend {
Expand Down
Loading