Allow to skip --parachain-id#102
Merged
shawntabrizi merged 1 commit intoparitytech:masterfrom Jul 7, 2021
Merged
Conversation
Member
|
@h4x3rotab sorry i think this is a little icky... Can we do something like: if the id is missing, and there is nothing hard coded, then throw an error. Otherwise, if id is missing, use what is embedded. If id is specified, use that. |
Contributor
Author
|
Thanks for the feedback. Do you think we can make it this way:
For some node implementations where |
Member
|
@h4x3rotab yeah something like that seems fine. Basically i do not want to introduce a new flag saying to skip some other flag. I want that behavior to be determined implicitly from either including or excluding the |
4932d49 to
2ffc163
Compare
Contributor
Author
|
@shawntabrizi Fixed as you suggested and rebased to the latest commit |
Contributor
Author
|
Kindly ping |
shawntabrizi
approved these changes
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some situation, we already have the parachain id embedded in the chain spec file, and thus
--parachain-idis not used (and maybe is even not supported in some node implementation).This PR introduces "skip_id_arg" option in ParachainConfig to deal with that.