You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Oliver Tale-Yazdi.unwrap():
Maybe we can add a "permission check" as part of the companion MR, sometimes it dies when trying to merge a companion since the bot cannot push to the branch. Exampls https://github.com/paritytech/cumulus/pull/1613/#issuecomment-1257677400
Mak
like - when you type bot merge from substrate, it will check if polkadot & cumulus MRs are pushable?
Oliver Tale-Yazdi.unwrap()
Maybe even when it realizes that you linked a companion. But yea; checking before merging upstream is the important part.
One of the solutions could be - when someone write "bot merge", there are list of checks that bot does, to make sure that all companions are mergeable - that could be a place to also check if companion PRs are pushable