You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice thanks will try to build my PR with that.
Any thoughts on moving this repo to polkadot-sdk so that we can have the crates versions managed by the existing process?
Any thoughts on moving this repo to polkadot-sdk so that we can have the crates versions managed by the existing process?
I don't think the existing process would have caught this issue. The problem is that macros generate code which they don't even depend on explicitly (e.g. impl-codec doesn't depend on uint but generates the code that uses it).
On the general topic of moving parity-common into polkadot-sdk: the original purpose for separation was that we'd share the code between (now obsolete) parity-ethereum and substrate.
Now it is more about sharing the code between polkadot-sdk and frontier. Although I'm not up-to-date with which dependencies are actually shared.
I think some crates in parity-common will be deprecated and removed (like kvdb-rocksdb with the switch to paritydb). What's left, might be replaced by more modern alternatives (e.g. #673)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #862 @pgherveou
I'll publish impl-codec 0.7 and primitive-types 0.13.1 and yank 0.13.0 (same for ethereum-types and ethbloom).
Hopefully, that's the only missing bump.