Skip to content

Adapt relayer to support syncing AssetHub parachains proof#3143

Merged
bkontur merged 32 commits intoparitytech:masterfrom
rosarp:rs-relay-parachains-cli
Apr 4, 2025
Merged

Adapt relayer to support syncing AssetHub parachains proof#3143
bkontur merged 32 commits intoparitytech:masterfrom
rosarp:rs-relay-parachains-cli

Conversation

@rosarp
Copy link
Copy Markdown
Member

@rosarp rosarp commented Mar 19, 2025 •
edited
Loading

Resolves #3136

Existing cli:

./substrate-relay relay-parachains rococo-to-bridge-hub-westend
./substrate-relay relay-parachains westend-to-bridge-hub-rococo
./substrate-relay relay-parachains polkadot-to-bridge-hub-kusama
./substrate-relay relay-parachains kusama-to-bridge-hub-polkadot

New cli options added:

./substrate-relay relay-parachains bridge-hub-rococo-to-bridge-hub-westend
./substrate-relay relay-parachains bridge-hub-westend-to-bridge-hub-rococo
./substrate-relay relay-parachains asset-hub-rococo-to-bridge-hub-westend
./substrate-relay relay-parachains asset-hub-westend-to-bridge-hub-rococo
./substrate-relay relay-parachains bridge-hub-polkadot-to-bridge-hub-kusama
./substrate-relay relay-parachains bridge-hub-kusama-to-bridge-hub-polkadot
./substrate-relay relay-parachains asset-hub-polkadot-to-bridge-hub-kusama
./substrate-relay relay-parachains asset-hub-kusama-to-bridge-hub-polkadot

TODO:

bkontur
bkontur reviewed Mar 20, 2025
View reviewed changes
Comment thread relay-clients/client-asset-hub-rococo/src/lib.rs Outdated
Comment thread relay-clients/client-asset-hub-rococo/src/lib.rs Outdated
Comment thread ...rate-relay/src/bridges/kusama_polkadot/asset_hub_kusama_parachains_to_bridge_hub_polkadot.rs Outdated
Comment thread ...rate-relay/src/bridges/kusama_polkadot/asset_hub_kusama_parachains_to_bridge_hub_polkadot.rs Outdated
Comment thread ...rate-relay/src/bridges/kusama_polkadot/asset_hub_kusama_parachains_to_bridge_hub_polkadot.rs Outdated
Comment thread substrate-relay/src/bridges/rococo_westend/asset_hub_rococo_parachains_to_bridge_hub_westend.rs Outdated
Comment thread substrate-relay/src/bridges/rococo_westend/asset_hub_westend_parachains_to_bridge_hub_rococo.rs Outdated
Comment thread substrate-relay/src/bridges/rococo_westend/asset_hub_westend_parachains_to_bridge_hub_rococo.rs Outdated
Comment thread ...rate-relay/src/bridges/kusama_polkadot/asset_hub_polkadot_parachains_to_bridge_hub_kusama.rs Outdated
Comment thread ...rate-relay/src/bridges/kusama_polkadot/asset_hub_polkadot_parachains_to_bridge_hub_kusama.rs Outdated
@bkontur bkontur self-requested a review March 20, 2025 10:16
rosarp and others added 9 commits March 20, 2025 17:24
@rosarp @bkontur
Update relay-clients/client-asset-hub-rococo/src/lib.rs
1b093d9 
Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
UtilityCall not required
0a7babf 
Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
Update substrate-relay/src/bridges/kusama_polkadot/asset_hub_kusama_p…
d9141f2 
…arachains_to_bridge_hub_polkadot.rs

Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
Update substrate-relay/src/bridges/kusama_polkadot/asset_hub_kusama_p…
01a64bf 
…arachains_to_bridge_hub_polkadot.rs


change to asset_hub

Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
Remove MessagesCliBridge in AHP parachains to BHK
8a469e4 
Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
Change to asset_hub in AHP parachains to BHK
1a25fb8 
Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
Change to asset_hub in AHP parachains to BHK
09fe328 
Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
Remove MessagesCliBridge in AHK parachains to BHP
fe49c1c 
Co-authored-by: Branislav Kontur <[email protected]>
@rosarp @bkontur
AssetHubRococo to AssetHubWestend messages
7f6cd9c 
Co-authored-by: Branislav Kontur <[email protected]>
rosarp
rosarp commented Mar 24, 2025
View reviewed changes
Comment thread substrate-relay/src/bridges/rococo_westend/asset_hub_rococo_parachains_to_bridge_hub_westend.rs Outdated
Comment thread substrate-relay/src/bridges/rococo_westend/asset_hub_rococo_parachains_to_bridge_hub_westend.rs Outdated
bkontur
bkontur reviewed Mar 24, 2025
View reviewed changes
Comment thread relay-clients/client-asset-hub-rococo/src/lib.rs Outdated
Comment thread relay-clients/client-asset-hub-westend/src/lib.rs Outdated
Comment thread substrate-relay/src/bridges/rococo_westend/asset_hub_rococo_messages_to_asset_hub_westend.rs Outdated
Comment thread substrate-relay/src/bridges/rococo_westend/asset_hub_westend_messages_to_asset_hub_rococo.rs Outdated
rosarp and others added 2 commits March 25, 2025 09:24
@rosarp @bkontur
Apply suggestions from code review
c7fecd8 
Change LegacyLaneId to HashedLaneId for AH relay chains
order correctly SuffixedCommonTransactionExtension args

Co-authored-by: Branislav Kontur <[email protected]>
@rosarp
changed to HashedLaneId for AH
59ea94e 
removed Ah change for kusama/polkadot
added relay messages
added TypeSubstitute for HashedLaneid
@rosarp rosarp marked this pull request as ready for review March 25, 2025 12:44
@rosarp rosarp requested review from acatangiu and serban300 March 25, 2025 13:18
@serban300
Copy link
Copy Markdown
Collaborator

serban300 commented Mar 27, 2025 •
edited
Loading

@rosarp what is the status of this PR ? Is it ready for review ? I see that there is still a TODO left. Also please fix the CI failures

@rosarp
Copy link
Copy Markdown
Member Author

rosarp commented Mar 29, 2025

@serban300 This PR is ready for review.
I was waiting for paritytech/polkadot-sdk#8063 to close.
CI will need to be re-run now as 8063 is now merged, this should resolve. will check that.

bkontur
bkontur reviewed Apr 3, 2025
View reviewed changes
Comment thread chains/chain-bridge-hub-kusama/src/lib.rs
@rosarp
added missing dep. of relay-ah client
7b181c8 
added DecodeWithMemTracking
replaced structopt with clap parser for cli
rosarp
rosarp commented Apr 3, 2025
View reviewed changes
Comment thread relay-clients/client-polkadot-bulletin/src/lib.rs Outdated
@rosarp
Copy link
Copy Markdown
Member Author

rosarp commented Apr 4, 2025 •
edited
Loading

@bkontur @serban300 can we use same CI image as polkadot-sdk?
this is using CI_IMAGE: paritytech/ci-unified:bullseye-1.81.0-2024-09-11-v202409111034
while polkadot-sdk using: 1.84.1 last i checked.

this PR failing here

@rosarp rosarp requested a review from a team as a code owner April 4, 2025 10:15
@serban300
Copy link
Copy Markdown
Collaborator

serban300 commented Apr 4, 2025

@bkontur @serban300 can we use same CI image as polkadot-sdk? this is using CI_IMAGE: paritytech/ci-unified:bullseye-1.81.0-2024-09-11-v202409111034 while polkadot-sdk using: 1.84.1 last i checked.

this PR failing here

Yes, that would be good

bkontur
bkontur reviewed Apr 4, 2025
View reviewed changes
Comment thread relay-clients/client-asset-hub-rococo/Cargo.toml Outdated
Comment thread relay-clients/client-asset-hub-westend/Cargo.toml Outdated
Comment thread relay-clients/client-polkadot-bulletin/src/lib.rs Outdated
Comment thread tools/runtime-codegen/src/main.rs Outdated
bkontur
bkontur reviewed Apr 4, 2025
View reviewed changes
Comment thread relay-clients/client-polkadot-bulletin/src/lib.rs Outdated
bkontur
bkontur reviewed Apr 4, 2025
View reviewed changes
Comment thread relay-clients/client-asset-hub-rococo/src/lib.rs Outdated
bkontur
bkontur reviewed Apr 4, 2025
View reviewed changes
Comment thread relay-clients/client-asset-hub-westend/src/lib.rs Outdated
bkontur
bkontur reviewed Apr 4, 2025
View reviewed changes
Comment thread relay-clients/client-asset-hub-rococo/src/lib.rs Outdated
bkontur
bkontur reviewed Apr 4, 2025
View reviewed changes
Comment thread relay-clients/client-asset-hub-westend/src/lib.rs Outdated
bkontur
bkontur reviewed Apr 4, 2025
View reviewed changes
Comment thread substrate-relay/src/cli/detect_equivocations.rs
},
};

use structopt::StructOpt;
Copy link
Copy Markdown
Collaborator

@bkontur bkontur Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosarp please, remove structopt from the main Cargo.toml/Cargo.lockl - as separate PR

bkontur
bkontur approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosarp good job, looks good, let's make the zombienet working for AH perm.lanes :)

@bkontur bkontur merged commit eb94744 into paritytech:master Apr 4, 2025
13 checks passed
@rosarp rosarp deleted the rs-relay-parachains-cli branch April 5, 2025 15:35
RomarQ pushed a commit to Moonsong-Labs/parity-bridges-common that referenced this pull request May 12, 2025
@rosarp @bkontur @RomarQ
Adapt relayer to support syncing AssetHub parachains proof (paritytec…
2749a0d 
…h#3143)

* initial commit - Adapt relayer to support syncing AssetHub parachains proof

* adding AH messages

* Update relay-clients/client-asset-hub-rococo/src/lib.rs

Co-authored-by: Branislav Kontur <[email protected]>

* UtilityCall not required

Co-authored-by: Branislav Kontur <[email protected]>

* Update substrate-relay/src/bridges/kusama_polkadot/asset_hub_kusama_parachains_to_bridge_hub_polkadot.rs

Co-authored-by: Branislav Kontur <[email protected]>

* Update substrate-relay/src/bridges/kusama_polkadot/asset_hub_kusama_parachains_to_bridge_hub_polkadot.rs

change to asset_hub

Co-authored-by: Branislav Kontur <[email protected]>

* Remove MessagesCliBridge in AHP parachains to BHK

Co-authored-by: Branislav Kontur <[email protected]>

* Change to asset_hub in AHP parachains to BHK

Co-authored-by: Branislav Kontur <[email protected]>

* Change to asset_hub in AHP parachains to BHK

Co-authored-by: Branislav Kontur <[email protected]>

* Remove MessagesCliBridge in AHK parachains to BHP

Co-authored-by: Branislav Kontur <[email protected]>

* AssetHubRococo to AssetHubWestend messages

Co-authored-by: Branislav Kontur <[email protected]>

* Apply suggestions from code review

* removed unsed UtilityCall & MessagesCliBridge

* renamed *CliBrige to *ParachainsCliBridge

* Apply suggestions from code review

Change LegacyLaneId to HashedLaneId for AH relay chains
order correctly SuffixedCommonTransactionExtension args

Co-authored-by: Branislav Kontur <[email protected]>

* changed to HashedLaneId for AH
removed Ah change for kusama/polkadot
added relay messages
added TypeSubstitute for HashedLaneid

* Fixed errors while aligning to polkadot-sdk master
removed WITH_CHAIN_RELAYERS_PALLET_NAME from ChainWithMessages

* added missing dep. of relay-ah client
added DecodeWithMemTracking
replaced structopt with clap parser for cli

* Apply suggestions from code review

Co-authored-by: Branislav Kontur <[email protected]>

* updating Cargo.lock with latest polkadot-sdk hash

* updating CI_IMAGE to align with polkadot-sdk

* fixed cargo check

* fixed cli args for substrate-relay

* Apply suggestions from code review

* Update relay-clients/client-polkadot-bulletin/src/lib.rs

* Update relay-clients/client-asset-hub-rococo/src/lib.rs

* Update relay-clients/client-asset-hub-westend/src/lib.rs

* Update relay-clients/client-asset-hub-rococo/src/lib.rs

* Update relay-clients/client-asset-hub-westend/src/lib.rs

---------

Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkontur bkontur bkontur approved these changes

@serban300 serban300 Awaiting requested review from serban300

@acatangiu acatangiu Awaiting requested review from acatangiu

Assignees

No one assigned

Labels

None yet

Projects

Bridges + XCM
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapt relayer to support syncing AssetHub parachains proof

3 participants

@rosarp @serban300 @bkontur