Gitspiegel polkadot staging#2695
Merged
svyatonik merged 2 commits intopolkadot-stagingfrom Nov 14, 2023
Merged
Conversation
Using a workflow to trigger mirroring instead of a webhook allows us to reuse "Approving workflow runs from public forks" GitHub feature to somewhat protect us from malicious PRs
The first attept to use a workflow to protect GitLab CI from untrusted contributors failed, because GitHub doesn't pass secrets to workflows for PRs that originate from forks. This uses a different approach: instead of triggerring gitspiegel API directly from the workflow, we're just spawning an empty workflow with a specific path, and gitspiegel listens for `workflow_run` event to start mirroring. The idea is the same: for the first-time contributors, running workflows would require manual aciton and that would block mirroring. But this time, we don't need any secrets to make it work.
bkontur
approved these changes
Nov 14, 2023
sergejparity
approved these changes
Nov 14, 2023
Contributor
Author
I think checks from above answers that. So nvm, thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mutantcornholio Could you, please, confirm that those two commits will fix our problem. And the problem is that when we open PRs to
polkadot-stagingbranch, no checks (apart from CLA) are running on that PR. For us it is important to run the same set of checks on PRs to bothmasterandpolkadot-stagingbranches.Example PRs:
polkadot-staging: Remove Woococo related stuff #2692 (no any checks)main: Finishing "Additional priority boost for relayers that have explicitly registered at lane" #2605