Skip to content

Implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub#2285

Merged
svyatonik merged 2 commits intomasterfrom
xcm-over-bridge-as-exporter-and-dispatcher
Jul 20, 2023
Merged

Implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub#2285
svyatonik merged 2 commits intomasterfrom
xcm-over-bridge-as-exporter-and-dispatcher

Conversation

@svyatonik
Copy link
Copy Markdown
Contributor

@svyatonik svyatonik commented Jul 20, 2023

This PR relates to:

So this PR adds implementation of ExportXcm and MessageDispatch to the recent pallet-xcm-bridge-hub. In the future we'll migrate Rialto<>Millau and then other bridges to this pallet, so bridge_runtime_common::XcmBlobHaulerAdapter and bridge_runtime_common::XcmBlobMessageDispatch will dissolve. Right now it's just a code that isn't used anywhere, bu as I mentioned, I need it to progress on #2261.

If we'll be implementing dynamic fees in V1 (without dynamic lanes), we'll probably keep using existing bridge_runtime_common::XcmBlobHaulerAdapter and bridge_runtime_common::XcmBlobMessageDispatch. Then we'll need a totally separate PR to the polkadot-staging branch.

@svyatonik svyatonik added P-Runtime PR-audit-needed A PR has to be audited before going live. labels Jul 20, 2023
@@ -0,0 +1,103 @@
// Copyright 2019-2021 Parity Technologies (UK) Ltd.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is almost 1:1 copy of the XcmBlobMessageDispatch. The only difference is that it is now implemented for the Pallet, instead of a dedicated struct

@@ -0,0 +1,184 @@
// Copyright 2019-2021 Parity Technologies (UK) Ltd.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I had to change the original XcmBlobHaulerAdapter a bit, because it doesn't work well with dynamic lanes. So it needs more careful review

@svyatonik svyatonik merged commit 9490834 into master Jul 20, 2023
@svyatonik svyatonik deleted the xcm-over-bridge-as-exporter-and-dispatcher branch July 20, 2023 14:34
bkontur pushed a commit that referenced this pull request May 7, 2024
)

* implement ExportXcm and MessageDispatch for pallet-xcm-bridge-hub

* spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-Runtime PR-audit-needed A PR has to be audited before going live.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants