Conversation
svyatonik
added
the
A-chores
bkontur
approved these changes
Jul 19, 2023
Collaborator
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
I went through, looks ok to me
serban300
approved these changes
Jul 19, 2023
acatangiu
approved these changes
Jul 19, 2023
svyatonik
added a commit
that referenced
this pull request
Jul 19, 2023
* cargo update -p parachain-info * flush * it compiles * clippy * temporary add more logging to cargo deny * Revert "temporary add more logging to cargo deny" This reverts commit 20daa88. * list installed Rust binaries before running cargo deny * changed prev commit * once again * try cargo update? * post-update fixes (nothing important)
svyatonik
added a commit
that referenced
this pull request
Jul 19, 2023
* cargo update -p parachain-info * flush * it compiles * clippy * temporary add more logging to cargo deny * Revert "temporary add more logging to cargo deny" This reverts commit 20daa88. * list installed Rust binaries before running cargo deny * changed prev commit * once again * try cargo update? * post-update fixes (nothing important)
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* cargo update -p parachain-info * flush * it compiles * clippy * temporary add more logging to cargo deny * Revert "temporary add more logging to cargo deny" This reverts commit 20daa88. * list installed Rust binaries before running cargo deny * changed prev commit * once again * try cargo update? * post-update fixes (nothing important)
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* cargo update -p parachain-info * flush * it compiles * clippy * temporary add more logging to cargo deny * Revert "temporary add more logging to cargo deny" This reverts commit 20daa88. * list installed Rust binaries before running cargo deny * changed prev commit * once again * try cargo update? * post-update fixes (nothing important)
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* cargo update -p parachain-info * flush * it compiles * clippy * temporary add more logging to cargo deny * Revert "temporary add more logging to cargo deny" This reverts commit 20daa88. * list installed Rust binaries before running cargo deny * changed prev commit * once again * try cargo update? * post-update fixes (nothing important)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
another deps update needed for #2261
the PR is not yet ready - just showing some progress on that
Unfortunately, I had to revert most of changes to bridges subtree from paritytech/cumulus#2790. I've missed the fact that the
Blockis now used in bridge primitives, which is not good - we don't have an access to extrinsic type there, so we don't (and won't need) to know the block type. So I'm reverting changes to ourChaintrait. This also means that I'll backport those (my) changes to thepolkadot-stagingafter merging this PR to master.We also need to think of adding our crates to workspace level
Cargo.tomlin Cumulus. Some stuff here doesn't even compiles (my guess - haven't checked it in Cumulus subtree).