Relayers pallet: extend payment source id#1907
Merged
serban300 merged 8 commits intoparitytech:masterfrom Feb 28, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing this comment and also addressing #1692
2 questions however (for future PRs maybe):
This approach might make it more complicated for the relayer to claim rewards. It will have to execute a
claim_rewardscall for each(lane_id, bridged_chain_id, lane_direction). Could this be an inconvenience ? Should we make it easier for the relayer ? Maybe modifyclaim_rewardsin order to handleLaneDirection::InandLaneDirection::Outat once ?Right now we have 2 steps for awarding rewards:
registering the reward
the relayer claims the reward
What if the account that pays the reward doesn't have funds at step 2 ? Can this occur ? It may not have funds in the first place, or it may have funds when registering the rewards, and spend them until the relayer claims the reward. Should / could we handle this ? Maybe freeze some funds at step 1 ?