Conversation
Break down in folders and make code compile Add skeleton wip wip wip update build update reorganise code wip
pgherveou
commented
Aug 3, 2023
pgherveou
commented
Aug 3, 2023
Collaborator
Author
There was a problem hiding this comment.
I am using latest master for now for polkadot and substrate, we can pin it to 1.0.0 if needed (this will be a bit annoying to refactor test but should be doable)
pgherveou
commented
Aug 3, 2023
| /// Returns the query id. | ||
| /// TODO: timeout should be generic over the BlockNumber but chain_extension does not support generics. | ||
| #[ink(extension = 3)] | ||
| fn new_query(timeout: DefaultBlockNumber, match_querier: VersionedMultiLocation) -> u64; |
Collaborator
Author
There was a problem hiding this comment.
not sure what's our best option here to pass the timeout, since we can't use generics...
pgherveou
commented
Aug 3, 2023
|
|
||
| // Attempt to take a response for the specified query. | ||
| Command::TakeResponse => { | ||
| log::debug!(target: LOG_TARGET, "Take XCM query response"); |
Collaborator
Author
There was a problem hiding this comment.
a better option here is maybe to make the type Encode, Decode upstream and just return that to the caller...
pgherveou
force-pushed
the
pg/update-xcm
branch
from
abf5c99 to
4051432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1 #6 #7 paritytech/polkadot-sdk#121