tests: Add sysctl ipv6 and extra CI steps#63
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
|
@lexnv Do you think we should keep both |
|
I think we could keep the |
This reverts commit 1e16a28.
This reverts commit 32ea0ca.
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
|
@dmitry-markin Let me know what you think of it, since I've change quite a few things. CI steps that are running now:
While at it, I've also fixed cargo doc tests. I've added At the moment, the clippy step is allowed to fail to not block this PR further and a proper fix should land with: #57. |
Makes sense to me. Overall, you changes seem to be a big improvement, thank you! One thing I don't understand / don't know how to check are all that github CI actions like: Not sure, how do we select the audited/trusted ones? (But may be if they work that's all we need to know.) |
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Changes the binding in response to
localhostinside a container fails because ::1 doesn't exist docker/for-linux#1374This is achieved via
--sysctl net.ipv6.conf.all.disable_ipv6=0CI steps that are running now:
While at it, I've also fixed cargo doc tests.
I've added
reorder_imports(similar to Substrate) to group imports from the same crate.At the time being, the clippy step is allowed to fail to not block this PR further and a proper fix should land with: #57.
Builds on #56