refactor: merge open_connection into negotiate_connection#459
Open
iTranscend wants to merge 2 commits intoparitytech:masterfrom
Open
refactor: merge open_connection into negotiate_connection#459iTranscend wants to merge 2 commits intoparitytech:masterfrom
iTranscend wants to merge 2 commits intoparitytech:masterfrom
Conversation
Collaborator
dmitry-markin
left a comment
dmitry-markin
left a comment
There was a problem hiding this comment.
I don't know what @lexnv had in mind when created the issue, but it seems a free-standing function was replaced with an async block. IMO this reduces readability and I would look into other options to simplify the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges
open_connection()intonegotiate_connection().resolves #347