Skip to content

transport: Fix pending dials memory leak #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexnv merged 2 commits into from
Oct 24, 2024
Merged

transport: Fix pending dials memory leak #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e538ad
transport: Fix pending dials leak
lexnv Oct 22, 2024
aac6891
Merge branch 'master' into lexnv/fix-manager-leak
lexnv Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/transport/tcp/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,7 @@ impl Stream for TcpTransport {
Ok(connection) => {
let peer = connection.peer();
let endpoint = connection.endpoint();
self.pending_dials.remove(&connection.connection_id());
self.pending_open.insert(connection.connection_id(), connection);

return Poll::Ready(Some(TransportEvent::ConnectionEstablished {
Expand Down
1 change: 1 addition & 0 deletions src/transport/websocket/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,7 @@ impl Stream for WebSocketTransport {
Ok(connection) => {
let peer = connection.peer();
let endpoint = connection.endpoint();
self.pending_dials.remove(&connection.connection_id());
self.pending_open.insert(connection.connection_id(), connection);

return Poll::Ready(Some(TransportEvent::ConnectionEstablished {
Expand Down