Skip to content

kad: Do not update memory store on incoming GetRecordSuccess #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexnv merged 5 commits into from
Jul 31, 2024
Merged

kad: Do not update memory store on incoming GetRecordSuccess #190

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
985ecf9
kad: Do not udpate memory store on incoming GetRecordSuccess
lexnv Jul 31, 2024
2d1a4b4
kad/tests: Expect to not find record in the memory store
lexnv Jul 31, 2024
01cc79b
Update src/protocol/libp2p/kademlia/mod.rs
lexnv Jul 31, 2024
4d3b64f
Update src/protocol/libp2p/kademlia/mod.rs
lexnv Jul 31, 2024
45daaaf
Merge branch 'master' into lexnv/avoid-peeerstore-overload
lexnv Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 4 additions & 31 deletions src/protocol/libp2p/kademlia/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,31 +656,6 @@ impl Kademlia {
Ok(())
}
QueryAction::GetRecordQueryDone { query_id, records } => {
// Considering this gives a view of all peers and their records, some peers may have
// outdated records. Store only the record which is backed by most
// peers.
let now = std::time::Instant::now();
let rec = records
.iter()
.filter_map(|peer_record| {
if peer_record.record.is_expired(now) {
None
} else {
Some(&peer_record.record)
}
})
.fold(HashMap::new(), |mut acc, rec| {
*acc.entry(rec).or_insert(0) += 1;
acc
})
.into_iter()
.max_by_key(|(_, v)| *v)
.map(|(k, _)| k);

if let Some(record) = rec {
self.store.put(record.clone());
}

let _ = self
.event_tx
.send(KademliaEvent::GetRecordSuccess {
Expand Down Expand Up @@ -976,9 +951,8 @@ mod tests {
let action = QueryAction::GetRecordQueryDone { query_id, records };
assert!(kademlia.on_query_action(action).await.is_ok());

// Check the local storage was updated.
let record = kademlia.store.get(&key).unwrap();
assert_eq!(record.value, vec![0x1]);
// Check the local storage should not get updated updated.
assert!(kademlia.store.get(&key).is_none());
}

#[tokio::test]
Expand Down Expand Up @@ -1017,8 +991,7 @@ mod tests {
let action = QueryAction::GetRecordQueryDone { query_id, records };
assert!(kademlia.on_query_action(action).await.is_ok());

// Check the local storage was updated.
let record = kademlia.store.get(&key).unwrap();
assert_eq!(record.value, vec![0x2]);
// Check the local storage should not get updated updated.
assert!(kademlia.store.get(&key).is_none());
}
}