Merged
Conversation
ascjones
reviewed
Jul 12, 2022
These versions can't be constructed using this version of the crate anyways, so it doesn't really make sense to keep them.
HCastano
commented
Jul 13, 2022
We should change to using the derive macros once our CI's nightly compiler version gets updated.
Contributor
Author
|
The |
Contributor
Author
|
This builds fine with the |
Contributor
Author
|
@ascjones can you take another look at this? |
sergejparity
approved these changes
Aug 9, 2022
We're never able to construct this variant with this crate anymore, so it doesn't make sense to keep it.
Contributor
Author
|
Let's wait until we sort out the release details of |
Contributor
Author
|
Gonna |
and get the release train started
cmichi
pushed a commit
that referenced
this pull request
Aug 31, 2022
* Add `version` field to `InkProject` * Use `InkProject` directly in metadata codegen * Remove old metadata versions from version enum These versions can't be constructed using this version of the crate anyways, so it doesn't really make sense to keep them. * Manually implement `Default` We should change to using the derive macros once our CI's nightly compiler version gets updated. * Add metadata `V4` version option * Use my branch of `cargo-contract` in CI * Remove deprecated `V3` metadata We're never able to construct this variant with this crate anymore, so it doesn't make sense to keep it.
xermicus
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Add `version` field to `InkProject` * Use `InkProject` directly in metadata codegen * Remove old metadata versions from version enum These versions can't be constructed using this version of the crate anyways, so it doesn't really make sense to keep them. * Manually implement `Default` We should change to using the derive macros once our CI's nightly compiler version gets updated. * Add metadata `V4` version option * Use my branch of `cargo-contract` in CI * Remove deprecated `V3` metadata We're never able to construct this variant with this crate anymore, so it doesn't make sense to keep it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now the version of the ink! metadata/ABI was specified using a version key which
wrapped the whole ink! metadata struct (
MetadataVersioned(InkProject)).However, it is nicer to have a proper
versionfield as part of the ink! metadata objectso that it can be queried in a less-ambiguous way.
Closes #1289.