Optimize encoded-size of `SignedCommitment` by de-sh · Pull Request #186 · paritytech/grandpa-bridge-gadget

de-sh · 2021-05-18T16:02:43Z

Fixes #128

Creates a new, better compressed representation of SignedCommitment
Implement parity_scale_codec::Encode
Implement parity_scale_codec::Decode

…c<Signature> - Define TemporarySignature

cla-bot-2021 · 2021-05-18T16:02:55Z

User @de-sh, please sign the CLA here.

adoerr · 2021-05-19T04:33:17Z

@de-sh can you pls sign the contributors agreement (CLA) above?

de-sh · 2021-05-19T05:35:00Z

@de-sh can you pls sign the contributors agreement (CLA) above?

Hey, I think I did 😅

I am working with @tomusdrw to prepare the PR for merger.

adoerr · 2021-05-19T05:37:39Z

Looks like the Bot thinks otherwise

de-sh · 2021-05-19T06:39:07Z

The cla marker within the PR checks seem to be marked green.

de-sh · 2021-05-30T22:06:49Z

@tomusdrw seems like the hex literal for compressed version of SignedCommitment, can you check if this is proper.

tomusdrw

Great, thanks!

beefy-primitives/src/commitment.rs

Co-authored-by: Tomasz Drwięga <[email protected]>

tomusdrw

Looks good, few improvements noted.

beefy-primitives/src/commitment.rs

de-sh · 2021-06-27T09:32:09Z

Hey, so I wrote a test to ensure that future contributors don't perform updates that remove constraints regarding off-eight signature(len>8 & len%8 != 0). Could add it here if you want, till there, resides in this commit.

Do you feel we are ready to merge?

tomusdrw

lgtm! Have you considered using bitvec crate?

de-sh · 2021-06-28T14:30:44Z

Not really, I was trying to achieve a simple implementation without adding external dependencies. Would that have been the right way to go?

tomusdrw · 2021-06-28T19:57:18Z

No, I was asking just out of curiosity. I guess it would simplify bit conversion quite a lot, but since it's already solved I'm happy to avoid the extra dependency.

seunlanlege · 2021-11-17T12:49:34Z

looks like this pr needs to go to substrate, you want to handle that @de-sh

adoerr · 2021-11-17T13:00:32Z

This has not been merged on purpose so far. Merging this will break Snowforks's SnowBridge

seunlanlege · 2021-11-17T13:02:03Z

Merging this will break Snowforks's SnowBridge

They're big boys, they can handle it 😂 @musnit

musnit · 2021-11-17T14:26:42Z

Merging this will break Snowforks's SnowBridge

They're big boys, they can handle it 😂 @musnit

:D yeh once this is finalized and ready we can start working on including it

de-sh · 2021-11-17T18:29:35Z

looks like this pr needs to go to substrate, you want to handle that @de-sh

Can you lemme know what I can do?

tomusdrw · 2021-12-01T14:50:02Z

Can you lemme know what I can do?

@de-sh apologies for the delay. Could you please try to apply exactly the same code changes as in this PR, but to the https://github.com/paritytech/substrate/ repository? BEEFY code resides now there. I'm willing to fast-track this change this time to make sure we merge this before any real-world deployment.

@tomusdrw

* Include code from paritytech/grandpa-bridge-gadget#186 * Cargo fmt commitment.rs * Make changes suggested by @tomusdrw Co-authored-by: Tomasz Drwięga <[email protected]>

de-sh · 2021-12-07T06:51:43Z

Closing in favor of paritytech/substrate#10409

tomusdrw · 2021-12-07T07:45:28Z

Thank you @de-sh!!!

@tomusdrw

* Include code from paritytech/grandpa-bridge-gadget#186 * Cargo fmt commitment.rs * Make changes suggested by @tomusdrw Co-authored-by: Tomasz Drwięga <[email protected]>

@tomusdrw

* Include code from paritytech/grandpa-bridge-gadget#186 * Cargo fmt commitment.rs * Make changes suggested by @tomusdrw Co-authored-by: Tomasz Drwięga <[email protected]>

de-sh and others added 5 commits May 10, 2021 20:42

Refactor representation of Vec<Option<Signature>> as Vec<u128> and Ve…

1488196

…c<Signature> - Define TemporarySignature

Add compression logic

d80be92

Refactor imported name and trait impl

8d888d9

Fix compilation.

49c8a5c

Fix and finish implementing new encoder for SignedCommitment

fc6db82

Merge branch 'master' into bitfield

b7cddb5

Add From<Temp...> and codec::Decode for SignedCommitment<...>

3e122b5

de-sh force-pushed the bitfield branch from 9044799 to 3e122b5 Compare May 27, 2021 10:29

Remove extra bounds. (#2)

681b594

de-sh marked this pull request as ready for review May 30, 2021 20:59

de-sh added 2 commits May 31, 2021 03:10

Fix use of bitwise operation in decompression of Signatures

fc0a36f

Fix hex tested against encoding of compressed SignedCommitment

07cacba

de-sh added 2 commits May 31, 2021 03:53

Fix variable names for generic block size use

112adb7

Clippy suggestions

68c047e

tomusdrw reviewed May 31, 2021

View reviewed changes

de-sh and others added 4 commits May 31, 2021 19:21

Update beefy-primitives/src/commitment.rs

e7eddbe

Co-authored-by: Tomasz Drwięga <[email protected]>

Add simple struct documentation and rename variables

fafd5b6

Refactor out the use of From

a2fa0fc

Add test for large Singnatures where (1024*2+2)/3 Somes exist

d5d4b88

tomusdrw reviewed Jun 3, 2021

View reviewed changes

beefy-primitives/src/commitment.rs Outdated Show resolved Hide resolved

beefy-primitives/src/commitment.rs Outdated Show resolved Hide resolved

beefy-primitives/src/commitment.rs Show resolved Hide resolved

de-sh added 3 commits June 15, 2021 09:43

Simplify decoding

922103d

Fix for edge cases

49aacfc

Remove unecessary trait bounds and simply pack() & unpack()

cbe4f7d

tomusdrw reviewed Jun 17, 2021

View reviewed changes

beefy-primitives/src/commitment.rs Outdated Show resolved Hide resolved

Move to using encoder side fix to simplify decoder

1139296

tomusdrw approved these changes Jun 28, 2021

View reviewed changes

Merge remote-tracking branch 'paritytech/master' into bitfield

7211ca2

tomusdrw added the Z-breaking This change is breaking backward compatibiltiy on protocol level. label Jul 13, 2021

tomusdrw mentioned this pull request Jul 18, 2021

BEEFY protocol name should change in accordance to GRANDPA protocol name #240

Closed

de-sh added a commit to de-sh/substrate that referenced this pull request Dec 2, 2021

Include code from paritytech/grandpa-bridge-gadget#186

104a0cd

de-sh closed this Dec 7, 2021

Conversation

de-sh commented May 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-bot-2021 bot commented May 18, 2021

Uh oh!

adoerr commented May 19, 2021

Uh oh!

de-sh commented May 19, 2021

Uh oh!

adoerr commented May 19, 2021

Uh oh!

de-sh commented May 19, 2021

Uh oh!

de-sh commented May 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomusdrw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tomusdrw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

de-sh commented Jun 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomusdrw left a comment

Choose a reason for hiding this comment

Uh oh!

de-sh commented Jun 28, 2021

Uh oh!

tomusdrw commented Jun 28, 2021

Uh oh!

seunlanlege commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adoerr commented Nov 17, 2021

Uh oh!

seunlanlege commented Nov 17, 2021

Uh oh!

musnit commented Nov 17, 2021

Uh oh!

de-sh commented Nov 17, 2021

Uh oh!

tomusdrw commented Dec 1, 2021

Uh oh!

de-sh commented Dec 7, 2021

Uh oh!

tomusdrw commented Dec 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

de-sh commented May 18, 2021 •

edited

Loading

de-sh commented May 30, 2021 •

edited

Loading

de-sh commented Jun 27, 2021 •

edited

Loading

seunlanlege commented Nov 17, 2021 •

edited

Loading