Merged
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
bkchr
reviewed
Sep 14, 2024
frame-metadata/src/v16.rs
Outdated
| /// The type of the outermost Extra enum. | ||
| pub extra_ty: T::Type, | ||
| /// The signed extensions in the order they appear in the extrinsic. | ||
| pub signed_extensions: Vec<SignedExtensionMetadata<T>>, |
Member
There was a problem hiding this comment.
Suggested change
| pub signed_extensions: Vec<SignedExtensionMetadata<T>>, | |
| pub transaction_extensions: Vec<SignedExtensionMetadata<T>>, |
Do we want to rename it directly?
Contributor
Author
There was a problem hiding this comment.
Yep, we can do it now since its quite a small change :D Thanks for pointing this out 🙏 Have also renamed the struct SignedExtensionMetadata -> struct TransactionExtensionMetadata
frame-metadata/src/v16.rs
Outdated
| )] | ||
| pub struct ExtrinsicMetadata<T: Form = MetaForm> { | ||
| /// Extrinsic version. | ||
| pub version: u8, |
Member
There was a problem hiding this comment.
Maybe we could return a Vec<u8> that represents all the available versions.
frame-metadata/src/v16.rs
Outdated
Comment on lines
+51
to
+52
| /// The type of the `Runtime`. | ||
| pub ty: <PortableForm as Form>::Type, |
Member
There was a problem hiding this comment.
For what is this needed? I mean this type is just some dummy type.
Contributor
Author
There was a problem hiding this comment.
After briefly looking into subxt I didn't find any usage of this type 🤔 I believe we expose it in our metadata APIs and keep around, have removed it for now
pkhry
approved these changes
Sep 16, 2024
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
serialize Signed-off-by: Alexandru Vasile <[email protected]>
pkhry
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the metadata V16 to the frame-metadata crate, under the
unstablefeature flag.The u32 ID of the metadata V16 is currently
u32::MAXto mark the metadata as unstable.This PR paves the way towards collecting the metadata in substrate and enables the extraction of the metadata via the runtime API calls.
cc @paritytech/subxt-team