Don't dereference SubstrateBlock on revert#394
Merged
AlexandruCihodaru merged 13 commits intomasterfrom Nov 12, 2025
Merged
Conversation
update_latest took ownership of the Substrateblock and wrapped it in Arc::new. During the rollback/revert operations a caller might try to update the latest block to a block obtained by block_by_number. If one of the "Best" or "Finalized" subscription is lagging this could make block_by_number to return an strong reference. This prevents the caller to update the best block since it will not be able to unwrap the strong reference. Signed-off-by: Alexandru Cihodaru <alexandru.cihodaru@parity.io>
Signed-off-by: Alexandru Cihodaru <alexandru.cihodaru@parity.io>
alindima
reviewed
Nov 10, 2025
alindima
changed the title
iulianbarbu
approved these changes
Nov 11, 2025
iulianbarbu
left a comment
iulianbarbu
left a comment
There was a problem hiding this comment.
LGTM! Only to update to polkdaot-sdk/master after PG's PR is merged, before merging.
Signed-off-by: Alexandru Cihodaru <alexandru.cihodaru@parity.io>
alindima
reviewed
Nov 11, 2025
alindima
reviewed
Nov 11, 2025
iulianbarbu
reviewed
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_latest took ownership of the Substrateblock and wrapped it in Arc::new. During the rollback/revert operations a caller might try to update the latest block to a block obtained by block_by_number. If one of the "Best" or "Finalized" subscription is lagging this could make block_by_number to return an strong reference. This prevents the caller to update the best block since it will not be able to unwrap the strong reference.
Depends on: paritytech/polkadot-sdk#10252