Merged
Conversation
alexggh
approved these changes
Oct 23, 2025
| None | ||
| } | ||
| // Remove duplicate acceses in storage_recorder | ||
| fn revive_remove_duplicate_account_access(&self, _state: &mut crate::Cheatcodes) {} |
Author
There was a problem hiding this comment.
duplicate placeholder records are added in Inspector::call_with_executor/Inspector::create_common this ideally needs to be refactored and moved to strategies, but i'd rather wait and see how zk-foundry does it
iulianbarbu
pushed a commit
that referenced
this pull request
Oct 27, 2025
iulianbarbu
added a commit
that referenced
this pull request
Oct 27, 2025
This reverts commit 8129cfe.
iulianbarbu
added a commit
that referenced
this pull request
Oct 28, 2025
* anvil-polkadot: implement anvil_setCoinbase Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: added AURA based FindAuthor impl Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: add eth_coinbase and tests Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: polish code Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: apply fmt Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): test based on Multicall contract Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): adjust thresholds for timestamp tests on revert Signed-off-by: Iulian Barbu <[email protected]> * Update crates/anvil-polkadot/src/substrate_node/service/consensus.rs * anvil-polkadot: address feedback part 1 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address feedback part 2 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address feedback part 3 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address feedback part 4 Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): removed unnecessary sol call conversions Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot(tests): remove other redundant SollCall conversions Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: use Error::RuntimeApi Signed-off-by: Iulian Barbu <[email protected]> * Update crates/anvil-polkadot/src/substrate_node/service/consensus.rs * update to polkadot-sdk master (#352) * Tracing support (#350) * add tracing support to resolc mode * closes #328 * closes #329 * Revert "Tracing support (#350)" This reverts commit 8129cfe. * Revert "update to polkadot-sdk master (#352)" This reverts commit af2eda8. * anvil-polkadot(tests): fix test Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: fix rustfmt Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: use pallet-aura FindAuthor todo comment Signed-off-by: Iulian Barbu <[email protected]> * anvil-polkadot: address G feedback Signed-off-by: Iulian Barbu <[email protected]> --------- Signed-off-by: Iulian Barbu <[email protected]> Co-authored-by: Alin Dima <[email protected]> Co-authored-by: Pavlo Khrystenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pvmmode. #327, [Forge test][Tracing] Implement base tracers #328expect_emit,expect_revert,recordLogsandAccountAccessesNotes
suddenDuplicateContracterrors when using with latest master