forked from foundry-rs/foundry
-
Notifications
You must be signed in to change notification settings - Fork 8
anvil-polkadot: add impersonation #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ffef79c
anvil-polkadot(impersonation): add impersonate...
iulianbarbu 10a3388
anvil-polkadot(tests): add tracing support
iulianbarbu 225672c
anvil-polkadot(misc): fix warnings
iulianbarbu 0b86c79
anvil-polkadot: polish logging
iulianbarbu 6017530
anvil-polkadot(impersonation): add impersonate...
iulianbarbu d29afb0
anvil-polkadot(impersonation): testing all impersonation RPCs
iulianbarbu 14accf2
anvil-polkadot(impersonation): polish test
iulianbarbu 106567b
anvil-polkadot: customize addr recovery in ReceiptExtractor
iulianbarbu 69a8e92
anvil-polkadot: point to custom polkadot-sdk
iulianbarbu 481a292
anvil-polkadot: fix impersonation test
iulianbarbu 4fe4396
Cargo.lock: update to latest custom polkadot-sdk
iulianbarbu 5a09b1a
anvil-polkadot: update ReceiptExtractor constructor usage
iulianbarbu e5ff766
anvil-polkadot(tests): refactor send_transaction
iulianbarbu bd5dae5
anvil-polkadot: fix comments and revert newlines
iulianbarbu 31dcfd0
foundry-cli: revert change
iulianbarbu 4e60394
Cargo.lock: fix unwanted crates updates
iulianbarbu affa8e5
anvil-polkadot(tests): assert tx failure when auto impersonation is f…
iulianbarbu 61c25f0
anvil-polkadot: rename cheats manager to impersonation
iulianbarbu b4d4948
anvil-polkadot: cargo fmt fix
iulianbarbu bcc7555
anvil-polkadot: fix typo
iulianbarbu d37ae56
taplo: added config and formatted...
iulianbarbu 53fc8d8
Update crates/anvil-polkadot/tests/it/utils.rs
iulianbarbu dcdf5c3
Update crates/anvil-polkadot/tests/it/mining.rs
iulianbarbu 991d8c3
Cargo.toml: changed back to polkadot-sdk/master
iulianbarbu bcab3f9
anvil-polkadot: address feedback
iulianbarbu 5d489e0
tomls: revert formatting
iulianbarbu 6162666
taplo: remove config
iulianbarbu f9d868f
Merge branch 'master' into ib-add-impersonation
iulianbarbu 6e34608
anvil-polkadot(tests): parameterize auto_impersonate test with rstest
iulianbarbu cac0a84
anvil-polkadot(toml): fix cargo.toml formatting
iulianbarbu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| include = ["**/*.toml"] | ||
| exclude = [ | ||
| "**/*nested-1000.toml", | ||
| "**/node_modules/**", | ||
| "**/invalid/*", | ||
| "test-data/**", | ||
| "target", | ||
| ] | ||
|
|
||
| [formatting] | ||
|
|
||
| [[rule]] | ||
|
|
||
| [rule.formatting] | ||
| include = ["taplo.toml"] | ||
| keys = ["exclude"] | ||
|
|
||
| array_auto_collapse = false | ||
|
|
||
| [[rule]] | ||
|
|
||
| [rule.formatting] | ||
| include = ["**/Cargo.toml"] | ||
|
|
||
| array_auto_expand = false | ||
| inline_table_expand = false | ||
|
|
||
| [[rule]] | ||
|
|
||
| [rule.formatting] | ||
| align_entries = true | ||
|
|
||
| [[rule]] | ||
| include = ["**/Cargo.toml"] | ||
| keys = ["dependencies", "*-dependencies", "workspace"] | ||
|
|
||
| [rule.formatting] | ||
| reorder_keys = true | ||
| align_comments = true | ||
|
|
||
| [[rule]] | ||
| include = ["**/Cargo.toml"] | ||
| keys = ["package", "workspace.package"] | ||
|
|
||
| [rule.formatting] | ||
| reorder_keys = false | ||
| align_comments = true | ||
|
|
||
| [[rule]] | ||
| include = ["**/Cargo.toml"] | ||
| keys = ["features"] | ||
|
|
||
| [rule.formatting] | ||
| reorder_arrays = true | ||
|
|
||
| [[rule]] | ||
| include = ["pyproject.toml"] | ||
|
|
||
| [rule.formatting] | ||
| align_entries = true | ||
| reorder_keys = false | ||
| align_comments = true | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a CI step for checking this format? Because if we don't, it's not that useful. Not everyone uses a code editor that automatically uses taplo for formatting.
Also, where did we get this taplo format from? I am not a big fan of the rule which adds whitespace in order to align the = signs in dependency lists.
Overall I'm not really sure we need it at this point. Anyway, let's not bundle this in this PR, as it's unrelated and would be best to also ask the embedded EVM guys for feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add one. I can work on this in some other PR, once a taplo config makes its way into the repo.
It is not a matter of automatically using taplo with the code editor, but to configure it (assuming our code editors allows it). I thought that our team should have taplo configured already given we also opened in the past PRs against polkadot-sdk.
It is the taplo config used by the taplo-cli repo. Changing a rule or the entire taplo config is straight forward (with the caveat that all tomls from anvil-polkadot should be formatted afterward). I am fine with most of the rules, only to have all of us use the same ones.
Sure, we can ask. By then I'll revert my toml changes. I hoped we can align quickly behind some "battle tested" formatting, whichever that is and assumed people can comply easily with taplo formatting in their editors (given our previous polkadot-sdk practice), and preferences to be factored in incrementally. Will open a new PR on this subject, maybe with the formatting rules of polkadot-sdk (since we know them already).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert here: 5d489e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed taplo config: 6162666.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be useful, but we should request feedback on the other devs working on the repo (since it affects all of us) and make sure that it's enforced by CI (otherwise it's not that useful)