Return correct error instead of panicking if requested resolc version doesn't exist#23
Return correct error instead of panicking if requested resolc version doesn't exist#23
resolc version doesn't exist#23Conversation
|
Could you please add the unit tests? |
|
Please update the PR title to be more descriptive |
pkhry
changed the title
resolc version doesn't exist
done
done |
| let binary = versions.into_iter().next_back().expect("Can't be empty"); | ||
| let Some(binary) = versions.into_iter().next_back() else { | ||
| let message = if let Some(v) = &_resolc_version { | ||
| format!("`resolc` v{v} doesn't exist") |
There was a problem hiding this comment.
when we set unknown version for solc we get:
Error: Unknown version provided
maybe we should update the error message to Error: Unknown solc version provided?
And for resolc
Error: Unknown resolc version provided
WDYT?
There was a problem hiding this comment.
when we set unknown version for solc we get:
Error: Unknown version providedmaybe we should update the error message toError: Unknown solc version provided? And for resolcError: Unknownresolcversion providedWDYT?
Error: unknown version providedi can't find where this error is produced in code. do you have a link to it?- for
solcwe can have both autodetect and specific, sounsupportedsolcversioncan be added as a third message then. WDYT?
There was a problem hiding this comment.
I do not have it, I just see such message when using unknown solc version
There was a problem hiding this comment.
I do not have it, I just see such message when using unknown solc version
i can both come from svm-rs and rvm-rs
There was a problem hiding this comment.
I think that it does not make sense to change svm or rvm now
2 participants
return correct error when
resolcversion doesn't existCloses: paritytech/foundry-polkadot#126