Skip to content

fix: remove TWO_ADICITY check in KZG SRS generation #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seunlanlege wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove TWO_ADICITY check in KZG SRS generation #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/pcs/kzg/urs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,6 @@ impl<E: Pairing> URS<E> {
let n = n1.max(n2);
assert!(n > 0, "nothing to generate");

// Until ECFFT for more curves is implemented, see https://github.com/wborgeaud/ecfft-bn254.
//
// Assertion note: as `TWO_ADICITY` for the field can be >= 32 and on 32-bit machine targets
// `usize` is just 32-bit we move the check in the `u64` domain to avoid a panic.
assert!(
n as u64 <= 1u64 << E::ScalarField::TWO_ADICITY,
"number of bases exceeds curve 2-adicity"
);

let t_powers = start_timer!(|| format!("Computing {} scalars powers", n));
// tau^0, ..., tau^(n-1))
let powers_of_tau: Vec<E::ScalarField> = utils::powers(tau).take(n).collect();
Expand Down