Conversation
|
@bkchr Does it need review/approval or I can hit the merge button? |
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Having exclude by passing folders would also be nice.
src/update.rs
Outdated
| thread_local! { | ||
| /// Packages version - HashMap(name, version)` | ||
| pub static PACKAGES_VERSION: RefCell<HashMap<String, String>> = RefCell::new(HashMap::new()); | ||
| /// Cargo.lock from URL or FILE sources | ||
| pub static CARGO_LOCK: RefCell<Option<String>> = RefCell::new(None); | ||
| /// Excluded packages from version updating - HashMap(name, exclude)` | ||
| pub static EXCLUDED_PACKAGES: RefCell<HashMap<String, bool>> = RefCell::new(HashMap::new()); | ||
| } |
There was a problem hiding this comment.
Please no thread locals. Remove them please.
There was a problem hiding this comment.
Please no thread locals. Remove them please.
Out of curiosity, is there something wrong about using thread locals? is it a bad practice?
| fn get_version_by_source(package: &str, source: &VersionSource) -> Result<String> { | ||
| let version = match source { | ||
| VersionSource::CratesIO => { | ||
| let url = format!("https://crates.io/api/v1/crates/{}", package); |
There was a problem hiding this comment.
Are you sure that we don't generate too many requests? Maybe we should wait between requests a little bit.
There was a problem hiding this comment.
Are you sure that we don't generate too many requests? Maybe we should wait between requests a little bit.
I tested it and it works. Maybe thanks to reqwest::blocking?
|
looking forward to this as it simplifies maintenance work for parachain teams. |
4 participants
This PR aims to solve the problem discussed in this forum post: https://forum.polkadot.network/t/publish-substrate-to-crates-io/949/39?u=nachopal
It adds two new options to the
updatesubcommand:--version: this specifies the source of the versions to which the crates will be updated. There are three valid values:latest: it will query the latest crate version fromhttps://crates.io/Cargo.lock, for example:https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/Cargo.lockCargo.lock--exclude: this specifies the path to a TOML file where a[diener_exclude]manifest key is expected, listing the crates we do not want to be updated. (This applies to all kinds of updates, not only for--version)If it gets approved I can update the
README.md