This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Moving pallet-asset-tx-payment from cumulus to substrate#712
Merged
bkchr merged 10 commits intoparitytech:masterfrom Nov 19, 2021
georgesdib:asset-tx-payment-to-substrate
Merged
Moving pallet-asset-tx-payment from cumulus to substrate#712bkchr merged 10 commits intoparitytech:masterfrom georgesdib:asset-tx-payment-to-substrate
pallet-asset-tx-payment from cumulus to substrate#712bkchr merged 10 commits intoparitytech:masterfrom
georgesdib:asset-tx-payment-to-substrate
Conversation
KiChjang
reviewed
Nov 8, 2021
Memmlock2 was in double
apopiak
reviewed
Nov 10, 2021
Contributor
Author
|
After the substrate merge, this should now be in a good shape for a merge too. Please let me know if you disagree/suggestions? |
apopiak
approved these changes
Nov 19, 2021
Contributor
apopiak
left a comment
apopiak
left a comment
There was a problem hiding this comment.
LGTM, would wait for someone else to approve as well, though.
bkchr
approved these changes
Nov 19, 2021
Member
|
LGTM. |
Contributor
|
@georgesdib Thank you again for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #688.
The corresponding substrate PR is paritytech/substrate#10127.
@apopiak @nukemandan